Page MenuHomePhabricator

UserDef DI
Closed, ResolvedPublic

Description

Inject services like UserFactory into UserDef instead of using static User methods.
This will enable easier testing of REST Endpoints that use UserDef in their param settings definition (called from Handler::getParamSettings()).

Details

ProjectBranchLines +/-Subject
mediawiki/coremaster+74 -15
Customize query in gerrit

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 29 2020, 4:10 PM
nnikkhoui triaged this task as Medium priority.Jul 29 2020, 4:10 PM
nnikkhoui moved this task from Backlog to Doing on the Platform Team Workboards (Green) board.

Change 616908 had a related patch set uploaded (by Nikki Nikkhoui; owner: Nikki Nikkhoui):
[mediawiki/core@master] UserDef DI

https://gerrit.wikimedia.org/r/616908

Change 616908 had a related patch set uploaded (by Nikki Nikkhoui; owner: Nikki Nikkhoui):
[mediawiki/core@master] UserDef DI

https://gerrit.wikimedia.org/r/616908

Change 616908 merged by jenkins-bot:
[mediawiki/core@master] UserDef DI

https://gerrit.wikimedia.org/r/616908

nnikkhoui closed this task as Resolved.Mon, Aug 31, 5:19 PM