Page MenuHomePhabricator
Create Task
Maniphest T259145

UserDef DI
Closed, ResolvedPublic
Actions

Description

Inject services like UserFactory into UserDef instead of using static User methods.
This will enable easier testing of REST Endpoints that use UserDef in their param settings definition (called from Handler::getParamSettings()).

Details

ProjectBranchLines +/-Subject
mediawiki/coremaster+74 -15UserDef DI
Customize query in gerrit

Event Timeline

nnikkhoui created this task.Jul 29 2020, 4:10 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 29 2020, 4:10 PM
nnikkhoui triaged this task as Medium priority.Jul 29 2020, 4:10 PM
nnikkhoui moved this task from Backlog to Doing on the Platform Team Workboards (Green) board.
nnikkhoui added a project: Dependency injection.
gerritbot added a comment.Jul 29 2020, 7:30 PM

Change 616908 had a related patch set uploaded (by Nikki Nikkhoui; owner: Nikki Nikkhoui):
[mediawiki/core@master] UserDef DI

https://gerrit.wikimedia.org/r/616908

gerritbot added a project: Patch-For-Review.Jul 29 2020, 7:30 PM
WDoranWMF added a project: Platform Team Sprints Board (Sprint 0).Jul 31 2020, 12:13 PM
gerritbot added a comment.Aug 3 2020, 6:38 AM

Change 616908 had a related patch set uploaded (by Nikki Nikkhoui; owner: Nikki Nikkhoui):
[mediawiki/core@master] UserDef DI

https://gerrit.wikimedia.org/r/616908

gerritbot added a comment.Aug 5 2020, 5:02 PM

Change 616908 merged by jenkins-bot:
[mediawiki/core@master] UserDef DI

https://gerrit.wikimedia.org/r/616908

Pchelolo moved this task from Doing to Done on the Platform Team Workboards (Green) board.Aug 6 2020, 2:28 PM
Naike edited projects, added Platform Team Sprints Board (Sprint 1); removed Platform Team Sprints Board (Sprint 0).Aug 7 2020, 10:10 AM
Naike edited projects, added Platform Team Sprints Board (Sprint 2); removed Platform Team Sprints Board (Sprint 1).Aug 21 2020, 12:44 PM
Naike edited projects, added Platform Team Sprints Board (Sprint 1); removed Platform Team Sprints Board (Sprint 2).
nnikkhoui closed this task as Resolved.Mon, Aug 31, 5:19 PM
Content licensed under Creative Commons Attribution-ShareAlike 3.0 (CC-BY-SA) unless otherwise noted; code licensed under GNU General Public License (GPL) or other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL