Page MenuHomePhabricator

Image loader is not resilient (Uncaught Error: 'retryPath' must be set in options param. Received:)
Closed, ResolvedPublic

Description

There are a handful of errors in logstash relating to this error. This happens because ImageCarousel uses Router::getPath which can return an empty string if the hash fragment has cleared.

There's no need to display an error message if the hash fragment has cleared - the overlay has been closed.

https://gerrit.wikimedia.org/g/mediawiki/extensions/MobileFrontend/+/e132873e6aa849cffa2a411e6f8dbd92e0765438/src/mobile.mediaViewer/ImageCarousel.js#208

https://gerrit.wikimedia.org/g/mediawiki/extensions/MobileFrontend/+/e132873e6aa849cffa2a411e6f8dbd92e0765438/src/mobile.mediaViewer/LoadErrorMessage.js#17

https://logstash.wikimedia.org/app/kibana#/doc/logstash-*/logstash-2020.07.30/clienterror?id=AXOhHagvMQ_08tQatua1&_g=h@b74aee6

Event Timeline

Jdlrobson triaged this task as Medium priority.Jul 30 2020, 7:31 PM

Change 624123 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/extensions/MobileFrontend@master] Drop check for retryPath

https://gerrit.wikimedia.org/r/624123

Change 624123 merged by jenkins-bot:
[mediawiki/extensions/MobileFrontend@master] Drop check for retryPath

https://gerrit.wikimedia.org/r/624123

Seems to recur a fair bit so I think we should look into this sooner rather than later.