Page MenuHomePhabricator

RevisionStoreCacheRecord: Unable to load fresh row for rev_id: [id]
Closed, ResolvedPublicPRODUCTION ERROR

Description

Error

MediaWiki version: 1.36.0-wmf.2

message
Unable to load fresh row for rev_id: 49528928

Impact / Notes

Seeing a handful of these in wmf.2 for huwiki, arwiki, plwiki.

May duplicate T249904.

Details

Request ID
4710fae9-1909-462a-8825-d21352a9766f
Request URL
https://ar.wikipedia.org/w/index.php?title=%D8%AE%D8%A7%D8%B5:%D9%86%D9%82%D9%84_%D8%B5%D9%81%D8%AD%D8%A9&action=submit
Stack Trace
exception.trace
#0 /srv/mediawiki/php-1.36.0-wmf.2/includes/Revision/RevisionStoreCacheRecord.php(93): MediaWiki\Revision\RevisionStoreCacheRecord->loadFreshRow()
#1 /srv/mediawiki/php-1.36.0-wmf.2/includes/Storage/DerivedPageDataUpdater.php(860): MediaWiki\Revision\RevisionStoreCacheRecord->getUser(integer)
#2 /srv/mediawiki/php-1.36.0-wmf.2/includes/page/WikiPage.php(2112): MediaWiki\Storage\DerivedPageDataUpdater->prepareContent(User, MediaWiki\Storage\RevisionSlotsUpdate, boolean)
#3 /srv/mediawiki/php-1.36.0-wmf.2/extensions/FlaggedRevs/backend/FlaggedRevs.php(1015): WikiPage->prepareContentForEdit(WikitextContent, NULL, User)
#4 /srv/mediawiki/php-1.36.0-wmf.2/extensions/FlaggedRevs/backend/FlaggedRevsHooks.php(181): FlaggedRevs::autoReviewEdit(FlaggableWikiPage, User, MediaWiki\Revision\RevisionStoreRecord)
#5 /srv/mediawiki/php-1.36.0-wmf.2/includes/HookContainer/HookContainer.php(320): FlaggedRevsHooks::onPageMoveComplete(Title, Title, User, integer, integer, string, MediaWiki\Revision\RevisionStoreRecord)
#6 /srv/mediawiki/php-1.36.0-wmf.2/includes/HookContainer/HookContainer.php(131): MediaWiki\HookContainer\HookContainer->callLegacyHook(string, array, array, array)
#7 /srv/mediawiki/php-1.36.0-wmf.2/includes/HookContainer/HookRunner.php(2848): MediaWiki\HookContainer\HookContainer->run(string, array)
#8 /srv/mediawiki/php-1.36.0-wmf.2/includes/MovePage.php(732): MediaWiki\HookContainer\HookRunner->onPageMoveComplete(Title, Title, User, integer, integer, string, MediaWiki\Revision\RevisionStoreRecord)
#9 /srv/mediawiki/php-1.36.0-wmf.2/includes/libs/rdbms/database/Database.php(4457): MovePage->{closure}(Wikimedia\Rdbms\DatabaseMysqli, string)
#10 /srv/mediawiki/php-1.36.0-wmf.2/includes/deferred/AtomicSectionUpdate.php(39): Wikimedia\Rdbms\Database->doAtomicSection(string, Closure)
#11 /srv/mediawiki/php-1.36.0-wmf.2/includes/deferred/DeferredUpdates.php(467): AtomicSectionUpdate->doUpdate()
#12 /srv/mediawiki/php-1.36.0-wmf.2/includes/deferred/DeferredUpdates.php(344): DeferredUpdates::attemptUpdate(AtomicSectionUpdate, Wikimedia\Rdbms\LBFactoryMulti)
#13 /srv/mediawiki/php-1.36.0-wmf.2/includes/deferred/DeferredUpdates.php(278): DeferredUpdates::run(AtomicSectionUpdate, Wikimedia\Rdbms\LBFactoryMulti, Monolog\Logger, BufferingStatsdDataFactory, string)
#14 /srv/mediawiki/php-1.36.0-wmf.2/includes/deferred/DeferredUpdates.php(194): DeferredUpdates::handleUpdateQueue(array, string, integer)
#15 /srv/mediawiki/php-1.36.0-wmf.2/includes/MediaWiki.php(1113): DeferredUpdates::doUpdates(string)
#16 /srv/mediawiki/php-1.36.0-wmf.2/includes/MediaWiki.php(849): MediaWiki->restInPeace()
#17 /srv/mediawiki/php-1.36.0-wmf.2/includes/MediaWiki.php(861): MediaWiki->{closure}()
#18 /srv/mediawiki/php-1.36.0-wmf.2/includes/MediaWiki.php(582): MediaWiki->doPostOutputShutdown()
#19 /srv/mediawiki/php-1.36.0-wmf.2/index.php(53): MediaWiki->run()
#20 /srv/mediawiki/php-1.36.0-wmf.2/index.php(46): wfIndexMain()
#21 /srv/mediawiki/w/index.php(3): require(string)
#22 {main}

Event Timeline

brennen renamed this task from Unable to load fresh row for rev_id: 49528928 to RevisionStoreCacheRecord: Unable to load fresh row for rev_id: [id].Aug 5 2020, 6:28 PM
brennen added a project: User-brennen.
brennen moved this task from Backlog to Logs/Train on the User-brennen board.

Note that we have the following log message in RevisionStore log for this request:

2020-08-05 17:59:48 [4710fae9-1909-462a-8825-d21352a9766f] mw1389 arwiki 1.36.0-wmf.2 RevisionStore INFO: MediaWiki\Revision\RevisionStore::loadSlotRecords falling back to READ_LATEST. {"revid":"49528928","trace":"RevisionStore.php line 1233 calls wfBacktrace()
RevisionStore.php line 1354 calls MediaWiki\\Revision\\RevisionStore->loadSlotRecords()
- line - calls MediaWiki\\Revision\\RevisionStore->MediaWiki\\Revision\\{closure}()
RevisionSlots.php line 175 calls call_user_func()
RevisionSlots.php line 117 calls MediaWiki\\Revision\\RevisionSlots->getSlots()
RevisionRecord.php line 192 calls MediaWiki\\Revision\\RevisionSlots->getSlot()
RevisionRecord.php line 175 calls MediaWiki\\Revision\\RevisionRecord->getSlot()
WikiPage.php line 806 calls MediaWiki\\Revision\\RevisionRecord->getContent()
WikiPage.php line 976 calls WikiPage->getContent()
DerivedPageDataUpdater.php line 551 calls WikiPage->isCountable()
DerivedPageDataUpdater.php line 776 calls MediaWiki\\Storage\\DerivedPageDataUpdater->grabCurrentRevision()
WikiPage.php line 2112 calls MediaWiki\\Storage\\DerivedPageDataUpdater->prepareContent()
FlaggedRevs.php line 1015 calls WikiPage->prepareContentForEdit()
FlaggedRevsHooks.php line 181 calls FlaggedRevs::autoReviewEdit()
HookContainer.php line 320 calls FlaggedRevsHooks::onPageMoveComplete()
HookContainer.php line 131 calls MediaWiki\\HookContainer\\HookContainer->callLegacyHook()
HookRunner.php line 2848 calls MediaWiki\\HookContainer\\HookContainer->run()
MovePage.php line 732 calls MediaWiki\\HookContainer\\HookRunner->onPageMoveComplete()
Database.php line 4457 calls MovePage->{closure}()
AtomicSectionUpdate.php line 39 calls Wikimedia\\Rdbms\\Database->doAtomicSection()
DeferredUpdates.php line 467 calls AtomicSectionUpdate->doUpdate()
DeferredUpdates.php line 344 calls DeferredUpdates::attemptUpdate()
DeferredUpdates.php line 278 calls DeferredUpdates::run()
DeferredUpdates.php line 194 calls DeferredUpdates::handleUpdateQueue()
MediaWiki.php line 1113 calls DeferredUpdates::doUpdates()
MediaWiki.php line 849 calls MediaWiki->restInPeace()
MediaWiki.php line 861 calls MediaWiki->{closure}()
MediaWiki.php line 582 calls MediaWiki->doPostOutputShutdown()
index.php line 53 calls MediaWiki->run()
index.php line 46 calls wfIndexMain()
index.php line 3 calls require()

So I guess we've achieved in moving the same errors in T212428 to a later point, specifically form L776 to L860 in DerivedPageDataUpdater

Basically we need the same fallback for RevisionCacheRecord.

Change 618590 had a related patch set uploaded (by Ppchelko; owner: Ppchelko):
[mediawiki/core@master] RevisionStoreCacheRecord: Fallback to master for update callback.

https://gerrit.wikimedia.org/r/618590

Change 618590 merged by jenkins-bot:
[mediawiki/core@master] RevisionStoreCacheRecord: Fallback to master for update callback.

https://gerrit.wikimedia.org/r/618590

daniel claimed this task.
daniel added a subscriber: daniel.

Patch is merged, please reopen if the issue persists.