Update unit tests failing on non-English devices
Open, LowPublic
Actions

Assigned To

None

Authored By

	• Dmantena
	Aug 7 2020, 12:33 AM

Description

I was running into strange unit test failures while testing a PR, failures unrelated to the PR work, and (eventually) realized it was related to the primary language of the Simulator I was running the tests on. Some of unit tests rely on English language strings and US region specific formatting to be considered successes.

I think at minimum for the time being we should at least document that the unit tests require the device's language/region to be en-US.

Repro Steps

Set your device/Simulator's primary language to something other than English and region to something other than US in Settings > General > Language & Region (e.g. French/France)
Run the app's unit tests against that Simulator

Expected Results
All tests succeed.

Actual Results
Some tests fail.

Event Timeline

• Dmantena created this task.Aug 7 2020, 12:33 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 7 2020, 12:33 AM

• Dmantena updated the task description. (Show Details)Aug 7 2020, 12:54 AM

LGoto triaged this task as Medium priority.Aug 10 2020, 6:41 PM

LGoto moved this task from Needs Triage to Engineering Backlog on the Wikipedia-iOS-App-Backlog board.

LGoto added a project: iOS-app-v6.7.1-Bonefish-On-A-Fishing-Boat.

LGoto edited projects, added iOS-app-v6.7.2-Bonefish-On-A-Balloon; removed iOS-app-v6.7.1-Bonefish-On-A-Fishing-Boat.Sep 22 2020, 6:53 PM

LGoto lowered the priority of this task from Medium to Low.Sep 22 2020, 8:20 PM

• JMinor moved this task from Tasks from Product Backlog to Ready for Development on the iOS-app-v6.7.2-Bonefish-On-A-Balloon board.Sep 22 2020, 8:22 PM

LGoto edited projects, added iOS-app-v6.8-Manta-Ray-On-A-Riding-Mower; removed iOS-app-v6.7.2-Bonefish-On-A-Balloon.Sep 29 2020, 6:31 PM

LGoto removed a project: iOS-app-v6.8-Manta-Ray-On-A-Riding-Mower.Nov 24 2020, 7:39 PM

PR for documenting en-US requirement for passing tests:
https://github.com/wikimedia/wikipedia-ios/pull/3785

Tsevener added a project: iOS-app-v6.9.2-Carp-On-A-Hot-Air-Balloon.May 17 2022, 2:53 PM

Tsevener moved this task from Tasks from Product Backlog to Ready for Development on the iOS-app-v6.9.2-Carp-On-A-Hot-Air-Balloon board.May 20 2022, 11:39 PM

LGoto removed a project: iOS-app-v6.9.2-Carp-On-A-Hot-Air-Balloon.Jun 21 2022, 9:50 PM

@Tsevener
Hi everyone, i was thinking to fix this issue with the unit tests with the creation of a Localizable.strings in the test folder for each language and to introduce localization for strings the needs it for the test suit. This should resolve most of the test issues with the localization. I attach here some photos explaining how i would address this problem. Let me know if you consider it as a valuable solution, if so i could improve it for italian language and put in place the architecture. As a result only the new localization file would be needed to add in order to have test coverage in other languages.

Screenshot 2023-06-06 at 11.06.00.png (374×1 px, 50 KB)

Filippo.zazzeroni added a subscriber: Tsevener.Jun 6 2023, 4:09 PM

news on this part ?

https://github.com/wikimedia/wikipedia-ios/pull/4543 i've added a PR with my solution.

	F37095315: Screenshot 2023-06-06 at 11.06.12.png
	Jun 6 2023, 9:10 AM

	F37095314: Screenshot 2023-06-06 at 11.06.00.png
	Jun 6 2023, 9:10 AM

	F37095313: Screenshot 2023-06-06 at 11.06.27.png
	Jun 6 2023, 9:10 AM

Update unit tests failing on non-English devicesOpen, LowPublicActions

Description

Event Timeline

Update unit tests failing on non-English devices
Open, LowPublic
Actions