Page MenuHomePhabricator

Parameter help information incorrect using (parameter name) => (default value) and default is a string
Closed, ResolvedPublic

Description

One easy fix

This can be seen at the moment in enwiki's api help output for action=stabilize's expiry parameter. The problem is that PHP interprets $x[$i] as substr($x,$i,1) when $x is a string.

The attached patch is one easy way to fix it, or you could refactor makeHelpMsgParameters to treat $paramSettings in the same way getParameterFromSettings does.


Version: 1.16.x
Severity: normal

Attached:

Details

Reference
bz24016

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:09 PM
bzimport set Reference to bz24016.