Page MenuHomePhabricator

Enable mapframe tag for trwiki
Closed, ResolvedPublic


Hello. As per this discussion, we request the mapframe tag to be enabled for Turkish Wikipedia. If that's technically possible, please do so.

Event Timeline

Hello @Evrifaessa - The Kartographer extension is already enabled on the Turkish Wikipedia. See (look for Kartographer). Regards.

Evrifaessa renamed this task from Enable Kartographer for trwiki to Enable mapframe tag for trwiki.Aug 17 2020, 7:28 PM
Evrifaessa updated the task description. (Show Details)

@MarcoAurelio, just updated the task. Sorry for the conflict. See this page. The mapframe tags don't work in Turkish Wikipedia.

MarcoAurelio triaged this task as Low priority.
MarcoAurelio moved this task from Backlog to Config - to process on the Wikimedia-Site-requests board.

I found the issue. The Turkish Wikipedia is a wiki which operates Flagged Revisions. Therefore and as per T191585 the setting wgKartographerEnableMapFrame' was enabled which disabled <mapframe>.

MarcoAurelio added a subscriber: Catrope.

Ping to @Catrope to know if it is safe to enable mapframe on trwiki as a FlaggedRevs wiki.

Ping to @Catrope to know if it is safe to enable mapframe on trwiki as a FlaggedRevs wiki.

Quoting from T229726#5419327:

Yes, combining Kartographer with FlaggedRevsOverride causes some problems. We'll still enable Kartographer on your wiki if you want it, but you should know about this bug so that you can make an informed decision.

The bug happens when you have a <mapframe> tag with JSON inside it (used for markers on the map), this JSON is edited (to move/change the markers), and then a user views an older version of the page. In that situation, the map that was edited will break after some time (about an hour), and the user will see a blank grey rectangle instead of the map. On most wikis, users rarely view older versions of pages, but on wikis with FlaggedRevs it happens all the time: when a page has unapproved edits, most readers will be shown the approved/stable version by default, rather than the latest/unstable version. If the pending (unapproved) edits changed the markers on a map, these readers may see a broken map.

This page on test2wiki illustrates the situation in which the bug happens, but unfortunately it doesn't actually demonstrate the bug because static maps are not enabled there (I'll change that early next week, so that it breaks the way it's supposed to).

In summary:

  • When viewing the latest (possibly unapproved) version of a page
    • Everything works fine
  • When viewing an older (approved) version of a page
    • If the markers on the map were changed between the older (approved) and latest (unapproved) versions of the page
      • Then the map will break, and display a grey rectangle (but not immediately, it'll take up to an hour)
    • If the markers on the map were not changed
      • Then the map will display just fine

TLDR: Yes, it is possible and we can do it, but the community needs to acknowledge the bug, and we fine with it.

You can now see the bug in action on this page: (in my comment I said that you could see it there, but I was wrong, test2wiki wasn't configured right; now it is).

Because there's an unreviewed edit that changed the markers on the map, the map breaks when viewing the stable version (Read tab), but works when viewing the latest version (Pending changes tab).

I started another consensus about how this bug would affect us, I'll post the results here probably within a week.

Urbanecm changed the task status from Open to Stalled.Aug 19 2020, 4:56 PM

flagging as such :)

Evrifaessa changed the task status from Stalled to Open.Aug 22 2020, 3:45 PM

@Catrope, @Urbanecm, we made another community consensus. You can start working on enabling it :)

Change 622124 had a related patch set uploaded (by Urbanecm; owner: Urbanecm):
[operations/mediawiki-config@master] Enable mapframe at trwiki

Change 622124 merged by jenkins-bot:
[operations/mediawiki-config@master] Enable mapframe at trwiki

Mentioned in SAL (#wikimedia-operations) [2020-08-24T11:50:35Z] <urbanecm@deploy1001> Synchronized wmf-config/InitialiseSettings.php: e1ae39afbb4d6f33e74782580db7dfee06d0097d: Enable mapframe at trwiki (T260594) (duration: 00m 58s)

The change was just deployed.