Show name of default voice in menu
Closed, ResolvedPublic
Actions

Description

When selecting the voice in settings, show the voice name e.g. in parenthesis.

Details

	Subject	Repo	Branch	Lines +/-
	Show name of default voice in preferences	mediawiki/extensions/Wikispeech	master	+27 -4

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Sebastian_Berlin-WMSE	T260879 Show name of default voice in menu
		Resolved		Sebastian_Berlin-WMSE	T263115 Break out getDefaultVoice() to separate class

Event Timeline

Sebastian_Berlin-WMSE created this task.Aug 20 2020, 8:44 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 20 2020, 8:44 AM

Sebastian_Berlin-WMSE added a project: WMSE.Aug 20 2020, 8:50 AM

Sebastian_Berlin-WMSE edited projects, added Wikispeech-WMSE; removed WMSE.

Sebastian_Berlin-WMSE set the point value for this task to 2.

Sebastian_Berlin-WMSE moved this task from Incoming to Proposed for next sprint on the Wikispeech-Jobrunner board.

Lokal_Profil moved this task from Proposed for next sprint to Sprint on the Wikispeech-Jobrunner board.Aug 20 2020, 9:23 AM

Lokal_Profil edited projects, added Wikispeech-Jobrunner (Sprint); removed Wikispeech-Jobrunner.

Lokal_Profil moved this task from Unsorted to Player on the Wikispeech-Text-to-Speech board.Aug 20 2020, 11:52 AM

Sebastian_Berlin-WMSE added a project: User-Sebastian_Berlin-WMSE.Sep 1 2020, 7:42 AM

Sebastian_Berlin-WMSE moved this task from Backlog to This Week on the User-Sebastian_Berlin-WMSE board.

Lokal_Profil moved this task from Backlog to In progress on the Wikispeech-Jobrunner (Sprint) board.Sep 8 2020, 1:34 PM

This turned out to be less straightforward than I initially thought since the default is retrieved by UtteranceStore.

We have discussed that UtteranceStore is not the correct class for getDefaultVoice, but currently there is no natural home for this function.

As a pre-step to the default name patch. Move that function to a new Utilesque class.

Sebastian_Berlin-WMSE mentioned this in T263115: Break out getDefaultVoice() to separate class.Sep 17 2020, 10:30 AM

kalle added a project: User-kalle.Sep 25 2020, 11:07 PM

kalle moved this task from 🥴 Backlog to 😘 Review on the User-kalle board.

Change 630168 had a related patch set uploaded (by Sebastian Berlin (WMSE); owner: Sebastian Berlin (WMSE)):
[mediawiki/extensions/Wikispeech@master] Show name of default voice in preferences

https://gerrit.wikimedia.org/r/630168

gerritbot added a project: Patch-For-Review.Sep 28 2020, 12:49 PM

Sebastian_Berlin-WMSE moved this task from This Week to Waitin' on the User-Sebastian_Berlin-WMSE board.Sep 30 2020, 7:56 AM

Lokal_Profil assigned this task to Sebastian_Berlin-WMSE.Oct 1 2020, 8:31 AM

Change 630168 merged by Karl Wettin (WMSE):
[mediawiki/extensions/Wikispeech@master] Show name of default voice in preferences

https://gerrit.wikimedia.org/r/630168

Sebastian_Berlin-WMSE mentioned this in rEWIS20736a3faf87: Show name of default voice in preferences.Oct 14 2020, 9:27 PM

Maintenance_bot removed a project: Patch-For-Review.Oct 14 2020, 10:10 PM

Sebastian_Berlin-WMSE moved this task from Waitin' to Done on the User-Sebastian_Berlin-WMSE board.Oct 15 2020, 6:50 AM

Sebastian_Berlin-WMSE moved this task from In progress to Done on the Wikispeech-Jobrunner (Sprint) board.Oct 15 2020, 9:39 AM

Sebastian_Berlin-WMSE removed the point value for this task.Oct 15 2020, 9:43 AM

Sebastian_Berlin-WMSE closed this task as Resolved.Oct 15 2020, 11:13 AM