Task
If eligible, users receive a Library Bundle authorization in the Library Card platform. We then use this list of users for the Wikilink tool to determine editors who had access to content when they added a link on Wikimedia projects. This works well for approval-based partners because if a user is applying for access to a resource, we can be reasonably sure any subsequent citations they add were a result of that access. We can't be so sure for the Library Bundle because users are granted automatic access and to a wide range of publishers. We don't want to be inadvertently claiming that users are adding/removing citations to these Bundle publishers when we know that they haven't been active on the Library Card platform.
To solve this, we can add some additional logic to the AuthorizedUsers API view (https://github.com/WikipediaLibrary/TWLight/blob/master/TWLight/users/views.py#L675).
We should add something like the following code after we retrieve valid partner authorizations (https://github.com/WikipediaLibrary/TWLight/blob/master/TWLight/users/views.py#L695):
if partner.authorization_method = partner.BUNDLE:
valid_partner_auths = valid_partner_auths.filter(
user_last_login__gt=datetime.today() - timedelta(weeks=2)
)Where datetime and timedelta are imported from datetime. This code hasn't been tested, and is provided only as a suggestion, so you may need to alter it.
We should also add a new test (https://github.com/WikipediaLibrary/TWLight/blob/master/TWLight/tests.py#L1114) which verifies this behaviour, and ensure that previous tests still work as expected.
Good first task
This task has been placed in the good first task category. This means it has been scoped and written in a way that makes it simpler for folks who haven’t contributed to the tool’s development or open source software in the past.
If that’s you, welcome! Please feel free to ask questions here about this specific task or the codebase more generally. We’ll be more than happy to help you and clarify the steps needed to complete the task, whether that’s setting up the repository, implementing the necessary changes, or pushing your changes to Github.
If you have experience contributing to this project or similar ones, please consider leaving this one for someone new, and taking a look at the Open Tasks column of the workboard for another task. Also feel free to help out if you see unanswered questions here!
How to contribute
Assign yourself to this task: Click the ‘Add Action’ dropdown menu below and then select Assign / Claim. The box should fill your username in automatically, then click Submit!
To submit your changes, you should fork the repository and create a new branch. After pushing your changes to your Github branch, you can open a pull request. Please link your pull request in a comment here when it has been submitted, and include the Phabricator task number in the pull request. Experienced contributors to the project will review your code and either provide feedback or merge it in!