Per 3513c642dd53 @Mholloway introduced a new user group called "push subscription managers". By adding it to the extension.json file of Echo, this new group now exists in all Wikimedia wikis. @Majavah, @Urbanecm and myself wonder if this group needs to exist in all Wikimedia wikis or if it just needs to be Meta. In case it just needs to be Meta, perhaps we could amend wmf-config so the group exists just there? Thanks.
Description
Description
Details
Details
Related Objects
Related Objects
- Mentioned Here
- rOMWCb609cd53273e: Follow-up for a1b0d6e: Get $wgDBname in Echo's ext function
rOMWCa1b0d6e4e7da: CommonSettings.php: limit new Echo's `push-subscription-manager` group to Meta…
T260247: Push notification service should make deletion requests to MediaWiki for invalid or expired subscriptions
rECHO3513c642dd53: Create push subscription manager group/right to clean up dead subs
Event Timeline
Comment Actions
Ah, yes, we only need the push-subscription-managers group on metawiki. Thanks for checking!
Comment Actions
@Mholloway Thanks for your quick reply! I think I can code a patch for this one if that's okay.
Comment Actions
Change 623370 had a related patch set uploaded (by MarcoAurelio; owner: MarcoAurelio):
[operations/mediawiki-config@master] CommonSettings.php: limit new Echo's push-subscription-manager group to Meta-Wiki
Comment Actions
@Mholloway Patch above aims to suppress the group elsewhere but on Meta-Wiki. If you're okay I am scheduling this to be deployed in today's Morning BACON window in about 2 hours. Best regards.
Comment Actions
Thanks for the patch, @MarcoAurelio. I won't be able to give this a thorough review before then since I'd need to spend a bit of time studying the extension registration system and MW initialization in greater detail than I know it off the top of my head, but if other reviewers are willing to +2, that's fine with me.
Comment Actions
Change 623370 merged by jenkins-bot:
[operations/mediawiki-config@master] CommonSettings.php: limit new Echo's push-subscription-manager group to Meta-Wiki
Comment Actions
Change 623435 had a related patch set uploaded (by Urbanecm; owner: Urbanecm):
[operations/mediawiki-config@master] Follow-up for a1b0d6e: Get $wgDBname in Echo's ext function
Comment Actions
Change 623435 merged by jenkins-bot:
[operations/mediawiki-config@master] Follow-up for a1b0d6e: Get $wgDBname in Echo's ext function
Comment Actions
Mentioned in SAL (#wikimedia-operations) [2020-08-31T18:23:25Z] <urbanecm@deploy1001> Synchronized wmf-config/CommonSettings.php: a1b0d6e4e7da9bf45ae7381d2c1d9814e6b36498: b609cd53273e922cd8af5507660b9d10c6da09b3: CommonSettings.php: limit new Echos push-subscription-manager group to Meta-Wiki (T261625) (duration: 00m 54s)
Comment Actions
@Mholloway This should be fixed. Big thanks to @Urbanecm and @Majavah for their code-review and BACON and hotfix.
Comment Actions
Docs also added on-wiki: https://meta.wikimedia.org/wiki/Meta:Push_subscription_managers (Wikidata Item: https://www.wikidata.org/wiki/Q98768431)