Page MenuHomePhabricator
Create Task
Maniphest T263158

On This Day widget takes user to Russian(?) version of the page
Closed, ResolvedPublic
Actions

Description

https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=11506634

I noticed a bug upon updating to the latest release, the ‘on this day’ Home Screen widget on iOS 14 displays in English. When you tap on it to go into the app however it brings you to the Russian language version of the page (or rather, what I believe to be Russian, it is with Cyrillic characters and I unfortunately am not familiar with the language). Simply tapping out of that page brings you to the English language home page of the app as expected. My language is set to English in the app.

https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=11506422

There’s also a bug I’d like to report. I’m on the latest beta version (just moved over from the App Store version!) and tapping anywhere on the widget except for one of the article cards opens the Russian “On this day” screen, although I only have English and Spanish Wikipedia enabled. (See attached screen recording)

QuickTime_movie.mov2 MBDownload

Event Timeline

LGoto created this task.Sep 17 2020, 5:13 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 17 2020, 5:13 PM
LGoto updated the task description. (Show Details)Sep 17 2020, 5:18 PM
Tsevener subscribed.Sep 17 2020, 5:24 PM

Here's some test step weirdness I've noticed when testing with multiple languages:

  1. I had English as primary, German as secondary (+ a few other languages further down). On this day widget shows English and correctly deep links to English On This Day screen.
  2. Adjusted German to be primary. (Maybe refreshed Explore feed at this point). Widget still shows English. Tapping English widget takes you German On This Day.
  3. Deleted German language in Settings. Widget is still English. Tapping English widget takes you German On This Day.

If we can pass a content group object ID to the deep link, that might be the best way to keep these matching. We should also confirm a widget reload attempts as soon as languages are adjusted, and see what is causing English to remain in the widget even when you move another language to primary.

Also, test this functionality in the Top Read widget as well.

Tsevener added a project: iOS-app-v6.7.1-Bonefish-On-A-Fishing-Boat.Sep 17 2020, 5:24 PM
• MattCleinman claimed this task.EditedSep 17 2020, 6:58 PM
• MattCleinman moved this task from Tasks from Product Backlog to Doing on the iOS-app-v6.7.1-Bonefish-On-A-Fishing-Boat board.

Can confirm that the video is Russia's on this day for yesterday (when video was taken): https://ru.wikipedia.org/api/rest_v1/feed/onthisday/events/09/16

So the question becomes, why are we pulling in the Russian feed?

• MattCleinman added a comment.Sep 17 2020, 10:27 PM

PR for main part is merged: https://github.com/wikimedia/wikipedia-ios/pull/3701

Now working on the language funkiness Toni noted.

• MattCleinman added a comment.Sep 17 2020, 11:03 PM

Progress made: If this is threaded, it's a race condition. If it's not threaded, we're just pulling the data before we're setting the new language. It doesn't take two moves to get the language to update - it's always using the prior language.

To reproduce: Have three languages. If A is currently in use, switch to B, then switch to C, then check the widgets - they will show language B.

• MattCleinman added a comment.Sep 18 2020, 12:25 AM

It's possibly a context issue. When debugging, you can see the new language being updated appropriately, then trying to get the language from the widget, and there it shows as the outdated language.

Thoughts:

  • I tried calling updateAllWidgets when the WMFAppLanguageDidChange notification fired. That also didn't help.
  • We're using the feedImportContext when updating the feed... not sure if that is related.

Is there some reason the DataStore would return out of date information when the widgets are reloading? That seems to be what is happening here.

• MattCleinman added a comment.Sep 18 2020, 4:18 PM

This fix is being handled here: https://github.com/wikimedia/wikipedia-ios/pull/3703/

LGoto added a comment.Sep 18 2020, 4:46 PM

Additional feedback from a user with Finnish, English, and French:

https://ticket.wikimedia.org/otrs/index.pl?Action=AgentTicketZoom;TicketID=11509067

LGoto triaged this task as Medium priority.Sep 21 2020, 6:44 PM
LGoto moved this task from Needs Triage to Bug Backlog on the Wikipedia-iOS-App-Backlog board.
• MattCleinman moved this task from Doing to Needs Code Review on the iOS-app-v6.7.1-Bonefish-On-A-Fishing-Boat board.Sep 22 2020, 6:41 PM
• MattCleinman moved this task from Needs Code Review to Waiting for Build on the iOS-app-v6.7.1-Bonefish-On-A-Fishing-Boat board.Sep 23 2020, 12:22 AM
LGoto moved this task from Waiting for Build to Ready for PM Signoff on the iOS-app-v6.7.1-Bonefish-On-A-Fishing-Boat board.Sep 30 2020, 9:46 PM
• JMinor awarded a token.Oct 8 2020, 10:02 PM
• JMinor subscribed.

Da!

• JMinor closed this task as Resolved.Oct 8 2020, 10:02 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL