Page MenuHomePhabricator

Special:SecurePoll/edit doesn't always load existing custom message labels
Open, MediumPublicBUG REPORT

Description

See, eg, https://meta.wikimedia.beta.wmflabs.org/wiki/Special:SecurePoll/edit/17
Steps to reproduce:
Create a securepoll with:

poll type: Range voting (histogram range)
question: Question text
minimum score: -1
maximum score: 1
default score: 0
Use custom messages for column labels: enabled
custom messages: put anything for -1, 0, and 1

Save the poll, then go back and edit it

Expected result:
Existing custom messages for column labels are preloaded

Actual result:
Only the custom messages for -1 and 0 are loaded, the message for 1 is blank

I tried this again with -2, -1, 0, 1, and 2, and only 1 and 2 had there messages fail to preload. Perhaps its because they are positive?
The messages are still shown at the voting page though (https://meta.wikimedia.beta.wmflabs.org/wiki/Special:SecurePoll/vote/17)

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
DannyS712 changed the subtype of this task from "Task" to "Bug Report".Oct 2 2020, 10:08 PM
DannyS712 moved this task from Unsorted to Reports on the User-DannyS712 board.

Change 644362 had a related patch set uploaded (by Aaron Schulz; owner: Aaron Schulz):
[mediawiki/extensions/SecurePoll@master] [WIP] Fix broken custom labels due to lack of JS number casting

https://gerrit.wikimedia.org/r/644362

Change 644374 had a related patch set uploaded (by Tim Starling; owner: Tim Starling):
[mediawiki/extensions/SecurePoll@master] Fix signed/unsigned confusion in create page

https://gerrit.wikimedia.org/r/644374

Change 644362 abandoned by Aaron Schulz:
[mediawiki/extensions/SecurePoll@master] Fix broken custom labels due to lack of JS number casting

Reason:
Superseded

https://gerrit.wikimedia.org/r/644362

Change 644374 merged by jenkins-bot:
[mediawiki/extensions/SecurePoll@master] Fix signed/unsigned confusion in create page

https://gerrit.wikimedia.org/r/644374