Page MenuHomePhabricator
Create Task
Maniphest T264877

SonarQube should analyze all Search Platform projects
Closed, ResolvedPublic8 Estimated Story Points
Actions

Description

As a developer, I want timely feedback on the quality of my code so that I can correct it before merging when needed.

Most of our projects are analyzed by SonarQube, but we still don't have SonarQube analysis on:

AC:

  • discovery/analytics project is analyzed by SonarQube
  • MjoLniR is analyzed by SonarQube

Details

SubjectRepoBranchLines +/-
Add sonar properties and coverage configsearch/MjoLniRmaster+14 -2
jjb: Enable Sonar analysis for mjolnir buildsintegration/configmaster+21 -6
search/python: add proper options for sonar bot commentingintegration/configmaster+2 -0
Add verbose logging for sonarintegration/configmaster+1 -0
Bump sonar-scanner version for tox with sonar jobsintegration/configmaster+1 -1
Do not set target on master sonar analysisintegration/configmaster+5 -4
Update workdir for tox sonar scannerintegration/configmaster+1 -1
Add sonar scanner to discolyticsintegration/configmaster+40 -4
Add sonar scanner to discolyticswikimedia/discovery/analyticsmaster+8 -0
Customize query in gerrit

Related Objects

Event Timeline

Gehel created this task.Oct 7 2020, 12:43 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 7 2020, 12:43 PM
Gehel added a subscriber: zeljkofilipin.Oct 8 2020, 11:09 AM

@zeljkofilipin is interested in getting more knowledge on this area, please add him to any code review on this work.

kostajh subscribed.Oct 8 2020, 11:09 AM
zeljkofilipin awarded a token.Oct 8 2020, 11:37 AM
zeljkofilipin added a project: User-zeljkofilipin.
zeljkofilipin moved this task from Backlog 🪒 to Watching 📺 on the User-zeljkofilipin board.
Gehel moved this task from needs triage to Current work on the Discovery-Search board.Oct 12 2020, 3:24 PM
Gehel edited projects, added Discovery-Search (Current work); removed Discovery-Search.
EBernhardson moved this task from Incoming to Ready for Dev -- SWE on the Discovery-Search (Current work) board.Oct 19 2020, 5:08 PM
EBernhardson set the point value for this task to 8.Oct 19 2020, 5:12 PM
Mstyles mentioned this in T264873: Ensure that SonarQube is commenting on gerrit code reviews of the Search Platform team.Oct 27 2020, 2:50 PM
Gehel triaged this task as High priority.Oct 28 2020, 1:28 PM
zeljkofilipin removed a project: User-zeljkofilipin.Dec 22 2020, 7:04 PM
• Zbyszko claimed this task.Mar 3 2021, 3:02 PM
• Zbyszko moved this task from Ready for Dev -- SWE to In Progress on the Discovery-Search (Current work) board.
zeljkofilipin unsubscribed.Mar 4 2021, 10:30 AM
kostajh added a comment.Mar 4 2021, 1:58 PM

@Zbyszko for the python code in discovery/analytics you might find the config I have in research/mwaddlink useful, but I still haven't solved the code coverage import bit.

• Zbyszko added a comment.Mar 4 2021, 6:04 PM

Thanks @kostajh - I'll definitely look into that.

gerritbot added a comment.Mar 8 2021, 11:03 AM

Change 669769 had a related patch set uploaded (by ZPapierski; owner: ZPapierski):
[wikimedia/discovery/analytics@master] Add sonar scanner to discolytics

https://gerrit.wikimedia.org/r/669769

gerritbot added a project: Patch-For-Review.Mar 8 2021, 11:03 AM

Change 669770 had a related patch set uploaded (by ZPapierski; owner: ZPapierski):
[integration/config@master] Add sonar scanner to discolytics

https://gerrit.wikimedia.org/r/669770

• Zbyszko moved this task from In Progress to Needs review on the Discovery-Search (Current work) board.Mar 10 2021, 1:39 PM
gerritbot added a comment.Mar 12 2021, 10:44 AM

Change 669769 merged by ZPapierski:
[wikimedia/discovery/analytics@master] Add sonar scanner to discolytics

https://gerrit.wikimedia.org/r/669769

• Zbyszko mentioned this in rWDANa3be91d715f9: Add sonar scanner to discolytics.Mar 12 2021, 10:48 AM
gerritbot added a comment.Mar 12 2021, 10:50 AM

Change 669770 merged by jenkins-bot:
[integration/config@master] Add sonar scanner to discolytics

https://gerrit.wikimedia.org/r/669770

Maintenance_bot removed a project: Patch-For-Review.Mar 12 2021, 11:10 AM
gerritbot added a comment.Mar 12 2021, 11:21 AM

Change 671122 had a related patch set uploaded (by Hashar; owner: Hashar):
[integration/config@master] Update workdir for tox sonar scanner

https://gerrit.wikimedia.org/r/671122

gerritbot added a project: Patch-For-Review.Mar 12 2021, 11:21 AM
gerritbot added a comment.Mar 12 2021, 1:58 PM

Change 671122 merged by jenkins-bot:
[integration/config@master] Update workdir for tox sonar scanner

https://gerrit.wikimedia.org/r/671122

gerritbot added a comment.Mar 12 2021, 2:06 PM

Change 671142 had a related patch set uploaded (by ZPapierski; owner: ZPapierski):
[integration/config@master] Do not set target on master sonar analysis

https://gerrit.wikimedia.org/r/671142

gerritbot added a comment.Mar 12 2021, 3:13 PM

Change 671142 merged by jenkins-bot:
[integration/config@master] Do not set target on master sonar analysis

https://gerrit.wikimedia.org/r/671142

gerritbot added a comment.Mar 16 2021, 9:43 AM

Change 672667 had a related patch set uploaded (by ZPapierski; owner: ZPapierski):
[integration/config@master] Bump sonar scanner version

https://gerrit.wikimedia.org/r/672667

gerritbot added a comment.Mar 16 2021, 10:34 AM

Change 672686 had a related patch set uploaded (by ZPapierski; owner: ZPapierski):
[integration/config@master] Bump sonar-scanner version for tox with sonar jobs

https://gerrit.wikimedia.org/r/672686

gerritbot added a comment.Mar 16 2021, 11:30 AM

Change 672686 merged by jenkins-bot:
[integration/config@master] Bump sonar-scanner version for tox with sonar jobs

https://gerrit.wikimedia.org/r/672686

gerritbot added a comment.Mar 17 2021, 2:01 PM

Change 673022 had a related patch set uploaded (by ZPapierski; owner: ZPapierski):
[integration/config@master] Add verbose logging for sonar

https://gerrit.wikimedia.org/r/673022

gerritbot added a comment.Mar 17 2021, 5:24 PM

Change 673022 merged by jenkins-bot:
[integration/config@master] Add verbose logging for sonar

https://gerrit.wikimedia.org/r/673022

gerritbot added a comment.Mar 19 2021, 3:31 PM

Change 673518 had a related patch set uploaded (by Gehel; owner: Gehel):
[integration/config@master] search/python: add proper options for sonar bot commenting

https://gerrit.wikimedia.org/r/673518

gerritbot added a comment.Mar 19 2021, 3:58 PM

Change 673518 merged by jenkins-bot:
[integration/config@master] search/python: add proper options for sonar bot commenting

https://gerrit.wikimedia.org/r/673518

gerritbot added a comment.Apr 7 2021, 4:39 PM

Change 677613 had a related patch set uploaded (by ZPapierski; author: ZPapierski):

[search/MjoLniR@master] Add sonar properties and coverage config

https://gerrit.wikimedia.org/r/677613

gerritbot added a comment.Apr 8 2021, 8:14 AM

Change 677813 had a related patch set uploaded (by ZPapierski; author: ZPapierski):

[integration/config@master] jjb:Enable Sonar analysis for mjolnir builds

https://gerrit.wikimedia.org/r/677813

gerritbot added a comment.May 6 2021, 2:51 AM

Change 677813 merged by jenkins-bot:

[integration/config@master] jjb: Enable Sonar analysis for mjolnir builds

https://gerrit.wikimedia.org/r/677813

Stashbot added a comment.May 6 2021, 2:52 AM

Mentioned in SAL (#wikimedia-releng) [2021-05-06T02:52:44Z] <James_F> jjb: Enable Sonar analysis for mjolnir builds T264877

• Zbyszko moved this task from Needs review to Needs Reporting on the Discovery-Search (Current work) board.May 17 2021, 3:29 PM
Gehel closed this task as Resolved.May 19 2021, 2:54 PM
gerritbot added a comment.May 21 2021, 2:11 PM

Change 677613 merged by Gehel:

[search/MjoLniR@master] Add sonar properties and coverage config

https://gerrit.wikimedia.org/r/677613

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL