Maniphest T265798

Empty edit notices still shown if message is deliberately blanked
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Esanders
	Oct 17 2020, 3:27 PM

Tags

Referenced Files

	F32387837: image.png
	Oct 17 2020, 3:27 PM

Subscribers

Description

After setting MediaWiki:newarticletext to an empty string, an empty notice is shown:

image.png (128×405 px, 5 KB)

Reported here: https://www.mediawiki.org/w/index.php?title=Topic:Undblgtw1dvbhznm&topic_showPostId=vvzmoja3h36kigrs#flow-post-vvzmoja3h36kigrs

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Filter empty edit notices	mediawiki/extensions/VisualEditor	master	+4 -0

Customize query in gerrit

Related Objects

Mentioned In: T337633: Empty message 'editnotice-notext' is visible as an edit notice in VisualEditor and mobile apps

Event Timeline

Esanders created this task.Oct 17 2020, 3:27 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 17 2020, 3:27 PM

Change 634734 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/VisualEditor@master] Filter empty edit notices

https://gerrit.wikimedia.org/r/634734

gerritbot added a project: Patch-For-Review.Oct 17 2020, 3:32 PM

Demo: https://patchdemo.wmflabs.org/wikis/4d18881cb65a4c565e63e7bb31d672a2/w/index.php?title=New&action=edit&redlink=1&uselang=en

matmarex added a project: Editing-team (Kanban Board).Oct 19 2020, 7:41 PM

Change 634734 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Filter empty edit notices

https://gerrit.wikimedia.org/r/634734

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.14; 2020-10-20).Oct 19 2020, 8:00 PM

Maintenance_bot removed a project: Patch-For-Review.Oct 19 2020, 8:10 PM

matmarex moved this task from Inbox to Ready for Sign Off on the Editing-team (Kanban Board) board.Oct 19 2020, 8:17 PM

matmarex added a project: Skipped QA.

ppelberg closed this task as Resolved.Oct 23 2020, 1:25 AM

ppelberg claimed this task.

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptOct 23 2020, 1:25 AM

suffusion_of_yellow mentioned this in T337633: Empty message 'editnotice-notext' is visible as an edit notice in VisualEditor and mobile apps.May 27 2023, 7:22 PM