Page MenuHomePhabricator

Research to create service for RevisionDeleter
Open, Needs TriagePublic


The class RevisionDeleter is using some services in static code and it allows to create instances of class RevDelItem/RevDelList which may need also services and needs some kind of ObjectFactory

Event Timeline

Umherirrender renamed this task from Research to create servie for RevisionDeleter to Research to create service for RevisionDeleter.Oct 18 2020, 1:51 PM
DannyS712 moved this task from Unsorted to Next on the User-DannyS712 board.
DannyS712 added a subscriber: DannyS712.

Since T268713: Inject dependencies into RevDelList classes RevisionDeleter::createList now uses an ObjectFactory to inject services
If we turned RevisionDeleter into its own service and replaced the static methods with non-static equivalents, only an ObjectFactory needs to be injected - no other services are used within RevisionDeleter, and any services used within the RevDelItem (sub)classes should eventually be injected by the RevDelList (sub)classes and isn't referred to directly in RevisionDeleter