Page MenuHomePhabricator
Create Task
Maniphest T266191

Rename MentorManager::getAvailableMentors to MentorManager::getAutoAssignedMentors
Closed, ResolvedPublic
Actions

Description

MentorManager::getAutoAssignedMentors better describes getAvailableMentors's purpose, especially once the patch for T245639: Allow anyone to claim a mentee gets merged.

We should rename MentorManager::getAvailableMentors to MentorManager::getAutoAssignedMentors. Filling as a follow-up for the patch to make it easier to review.

Details

SubjectRepoBranchLines +/-
[refactor] Rename MentorManager::getAvailableMentors to getAutoAssignedMentorsmediawiki/extensions/GrowthExperimentsmaster+19 -19
Customize query in gerrit

Related Objects
Search...

Event Timeline

• Urbanecm_WMF created this task.Oct 21 2020, 9:52 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 21 2020, 9:52 PM
• Urbanecm_WMF claimed this task.Oct 21 2020, 9:52 PM
• Urbanecm_WMF triaged this task as Lowest priority.
Restricted Application added a project: User-Urbanecm_WMF. · View Herald TranscriptOct 21 2020, 9:52 PM
• Urbanecm_WMF added a subtask: T245639: Allow anyone to claim a mentee.Oct 21 2020, 9:53 PM
• Urbanecm_WMF moved this task from Untriaged to Engineering on the User-Urbanecm_WMF board.Oct 21 2020, 9:57 PM
• Urbanecm_WMF edited projects, added User-Urbanecm_WMF (Engineering); removed User-Urbanecm_WMF.
• Urbanecm_WMF moved this task from Backlog to Blocked on the User-Urbanecm_WMF (Engineering) board.
• Urbanecm_WMF moved this task from Blocked to Backlog on the User-Urbanecm_WMF (Engineering) board.Oct 28 2020, 10:57 AM
MMiller_WMF closed subtask T245639: Allow anyone to claim a mentee as Resolved.Nov 25 2020, 7:15 PM
• Urbanecm_WMF moved this task from Backlog to Later on the User-Urbanecm_WMF (Engineering) board.Feb 3 2021, 7:11 PM
gerritbot added a comment.Feb 3 2021, 8:09 PM

Change 661450 had a related patch set uploaded (by Urbanecm; owner: Urbanecm):
[mediawiki/extensions/GrowthExperiments@master] [refactor] Rename MentorManager::getAvailableMentors to getAutoAssignedMentors

https://gerrit.wikimedia.org/r/661450

gerritbot added a project: Patch-For-Review.Feb 3 2021, 8:09 PM
• Urbanecm_WMF moved this task from Later to In review on the User-Urbanecm_WMF (Engineering) board.Feb 3 2021, 8:09 PM
• Urbanecm_WMF edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.
• Urbanecm_WMF moved this task from Incoming to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.
gerritbot added a comment.Feb 6 2021, 3:58 PM

Change 661450 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] [refactor] Rename MentorManager::getAvailableMentors to getAutoAssignedMentors

https://gerrit.wikimedia.org/r/661450

• Urbanecm_WMF closed this task as Resolved.Feb 6 2021, 3:59 PM

Nothing to QA -> closing.

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.30; 2021-02-09).Feb 6 2021, 4:00 PM
Maintenance_bot removed a project: Patch-For-Review.Feb 6 2021, 4:10 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits