Page MenuHomePhabricator
Create Task
Maniphest T266359

Stop counting errors in Minerva
Closed, ResolvedPublic
Actions

Description

A while back we began counting errors for Minerva. Now we have real error logging with stack traces the benefits of this are diminishing, we are shipping bytes to users that are unnecessary and the tooling should be removed.

Acceptance criteria

Details

SubjectRepoBranchLines +/-
wgMinervaCountErrors config was removedoperations/mediawiki-configmaster+0 -8
Remove client side error countingmediawiki/skins/MinervaNeuemaster+1 -65
Customize query in gerrit

Event Timeline

Jdlrobson created this task.Oct 23 2020, 6:08 PM
Restricted Application added subscribers: Masumrezarock100, Aklapper. · View Herald TranscriptOct 23 2020, 6:08 PM
Jdlrobson added a subscriber: phuedx.Oct 23 2020, 6:08 PM
gerritbot added a comment.Oct 23 2020, 6:09 PM

Change 636073 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[mediawiki/skins/MinervaNeue@master] Remove client side error counting

https://gerrit.wikimedia.org/r/636073

gerritbot added a project: Patch-For-Review.Oct 23 2020, 6:09 PM
phuedx added a subscriber: polishdeveloper.Oct 26 2020, 10:36 AM

Post-merge follow-up tasks proposed by @polishdeveloper:

  • Remove the now-deprecated configuration variables from our production config
  • Document the deprecation of the configuration variables
    • IMO we should do this on the skin's wiki page
  • Mark the legacy WebClientError schema as deprecated
phuedx added a comment.Oct 26 2020, 10:48 AM
In T266359#6577750, @phuedx wrote:
  • Mark the legacy WebClientError schema as deprecated

Done in https://meta.wikimedia.org/w/index.php?title=Schema_talk%3AWebClientError&type=revision&diff=20578287&oldid=18334524

gerritbot added a comment.Oct 26 2020, 11:04 AM

Change 636073 merged by jenkins-bot:
[mediawiki/skins/MinervaNeue@master] Remove client side error counting

https://gerrit.wikimedia.org/r/636073

Maintenance_bot removed a project: Patch-For-Review.Oct 26 2020, 11:10 AM
ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.16; 2020-11-03).Oct 26 2020, 12:00 PM
Jdlrobson triaged this task as Medium priority.Oct 26 2020, 6:40 PM
Jdlrobson moved this task from Incoming to Kanbanana-FY-2020-21 on the Web-Team-Backlog board.
Jdlrobson edited projects, added Web-Team-Backlog (Kanbanana-FY-2020-21); removed Web-Team-Backlog.
Jdlrobson edited projects, added Web-Team-Backlog; removed Web-Team-Backlog (Kanbanana-FY-2020-21).
Jdlrobson updated the task description. (Show Details)
Jdlrobson assigned this task to ovasileva.Oct 26 2020, 6:47 PM
Jdlrobson moved this task from Incoming to Needs Prioritization on the Web-Team-Backlog board.
Jdlrobson updated the task description. (Show Details)
gerritbot added a comment.Dec 14 2020, 7:44 PM

Change 649434 had a related patch set uploaded (by Jdlrobson; owner: Jdlrobson):
[operations/mediawiki-config@master] wgMinervaCountErrors config was removed

https://gerrit.wikimedia.org/r/649434

gerritbot added a project: Patch-For-Review.Dec 14 2020, 7:44 PM
Jdlrobson edited projects, added Web-Team-Backlog (Kanbanana-FY-2020-21); removed Web-Team-Backlog.Dec 14 2020, 7:44 PM
Jdlrobson updated the task description. (Show Details)
Jdlrobson moved this task from Needs Analysis to Ready for Signoff on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.
gerritbot added a comment.Dec 16 2020, 7:05 PM

Change 649434 merged by jenkins-bot:
[operations/mediawiki-config@master] wgMinervaCountErrors config was removed

https://gerrit.wikimedia.org/r/649434

Jdlrobson closed this task as Resolved.Dec 16 2020, 7:07 PM
Jdlrobson updated the task description. (Show Details)
Stashbot added a comment.Dec 16 2020, 7:09 PM

Mentioned in SAL (#wikimedia-operations) [2020-12-16T19:09:30Z] <dcausse@deploy1001> Synchronized wmf-config/InitialiseSettings.php: T266359: wgMinervaCountErrors config was removed (duration: 01m 03s)

Maintenance_bot removed a project: Patch-For-Review.Dec 16 2020, 7:10 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits