Page MenuHomePhabricator
Create Task
Maniphest T266624

The default wiki-wide search on Incubator is broken (specific subwiki preference does work)
Closed, ResolvedPublic3 Estimated Story PointsBUG REPORT
Actions

Description

To reproduce: try searching for any term on Incubator which should yield some results, e.g. "Incubator". If you have set a test-wiki preference in your preferences (the possibility comes from the Incubator extension), you will get results within that test-wiki i.e. Wx/xxx/ pages. But if you have the general maintenance setting or no setting there, the search will never find any pages.

Details

SubjectRepoBranchLines +/-
Don't apply title prefix filter in Special:Search for site projectmediawiki/extensions/WikimediaIncubatormaster+17 -4
Don't apply title prefix filter in Special:Search for unset projectmediawiki/extensions/WikimediaIncubatormaster+12 -6
Customize query in gerrit

Event Timeline

MF-Warburg created this task.Oct 27 2020, 11:25 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 27 2020, 11:25 PM
Hydriz added a project: MediaWiki-extensions-WikimediaIncubator.Oct 28 2020, 3:11 AM
Hydriz subscribed.

The extension is quite outdated due to lots of regression, so a rewrite is probably needed to bring it back up-to-date.

DannyS712 changed the subtype of this task from "Task" to "Bug Report".Oct 28 2020, 3:21 AM
DannyS712 removed a subscriber: MediaWiki-extensions-WikimediaIncubator.
MF-Warburg added a comment.Oct 29 2020, 4:42 PM

Anything we can do as a temporary fix?

MF-Warburg added a subscriber: SPQRobin.Oct 29 2020, 4:43 PM
Krinkle added a project: Discovery-Search.EditedJun 21 2021, 7:08 PM
Krinkle subscribed.

The description of the default user preference is to search on "All (sub)wikis". Yet, it seems in practice, this means no wikis at all.

This is affecting maintenance work on the wiki, such as searching through templates, user scripts, interface messages, gadgets, etc.

For example: insource:/MyLanguage/ returns no results, when it is probably meant to return at least https://incubator.wikimedia.org/wiki/MediaWiki:Aboutpage.

I've tried dozens of variations, including without namespace filter, and without using insource, but still no results, no matter what I try.

Krinkle renamed this task from Search on Incubator is broken if you don't have a specific test-wiki set to The default wiki-wide search on Incubator is broken (specific subwiki preference does work).Jun 21 2021, 7:08 PM
MPhamWMF moved this task from needs triage to Current work on the Discovery-Search board.Jun 28 2021, 3:22 PM
MPhamWMF edited projects, added Discovery-Search (Current work); removed Discovery-Search.
EBernhardson subscribed.Jun 28 2021, 3:24 PM
MPhamWMF set the point value for this task to 3.Jun 28 2021, 3:53 PM
MPhamWMF moved this task from Incoming to Ready for Dev -- SWE on the Discovery-Search (Current work) board.
EBernhardson claimed this task.Aug 6 2021, 5:34 PM
EBernhardson moved this task from Ready for Dev -- SWE to In Progress on the Discovery-Search (Current work) board.
gerritbot added a comment.Aug 6 2021, 8:43 PM

Change 710609 had a related patch set uploaded (by Ebernhardson; author: Ebernhardson):

[mediawiki/extensions/WikimediaIncubator@master] Don't apply title prefix filter in Special:Search for unset project

https://gerrit.wikimedia.org/r/710609

gerritbot added a project: Patch-For-Review.Aug 6 2021, 8:43 PM
EBernhardson moved this task from In Progress to Needs review on the Discovery-Search (Current work) board.Aug 6 2021, 8:43 PM
gerritbot added a comment.Aug 13 2021, 9:25 PM

Change 710609 merged by jenkins-bot:

[mediawiki/extensions/WikimediaIncubator@master] Don't apply title prefix filter in Special:Search for unset project

https://gerrit.wikimedia.org/r/710609

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.19; 2021-08-16).Aug 13 2021, 10:00 PM
Maintenance_bot removed a project: Patch-For-Review.Aug 13 2021, 10:10 PM
EBernhardson moved this task from Needs review to To Be Deployed on the Discovery-Search (Current work) board.Aug 16 2021, 4:24 PM
EBernhardson moved this task from To Be Deployed to Needs Reporting on the Discovery-Search (Current work) board.Aug 23 2021, 5:54 PM

Example queries now return results when no site preference is set.

Krinkle closed this task as Resolved.Aug 26 2021, 3:51 AM
Krinkle reopened this task as Open.

Oops, I didn't see the Needs reporting state.

Gehel closed this task as Resolved.Aug 30 2021, 12:34 PM
MF-Warburg reopened this task as Open.Sep 20 2021, 10:09 PM

This is only solved for the "None/All" preference, not for the "Maintenance" wiki preference.

EBernhardson added a comment.Sep 20 2021, 10:31 PM

What should it do when set to the Maintenance wiki preference?

MF-Warburg added a comment.Sep 20 2021, 10:42 PM

The same as for None/All, i.e. don't apply a prefix but search the whole wiki.

gerritbot added a comment.Sep 21 2021, 8:31 PM

Change 722678 had a related patch set uploaded (by Ebernhardson; author: Ebernhardson):

[mediawiki/extensions/WikimediaIncubator@master] Don't apply title prefix filter in Special:Search for site project

https://gerrit.wikimedia.org/r/722678

gerritbot added a project: Patch-For-Review.Sep 21 2021, 8:31 PM
gerritbot added a comment.Sep 23 2021, 9:06 AM

Change 722678 merged by jenkins-bot:

[mediawiki/extensions/WikimediaIncubator@master] Don't apply title prefix filter in Special:Search for site project

https://gerrit.wikimedia.org/r/722678

Maintenance_bot removed a project: Patch-For-Review.Sep 23 2021, 9:10 AM
ReleaseTaggerBot added a project: MW-1.38-notes (1.38.0-wmf.2; 2021-09-28).Sep 23 2021, 10:00 AM
Gehel closed this task as Resolved.Sep 27 2021, 2:10 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL