Page MenuHomePhabricator

Email all commenters when a followup rev is being committed
Closed, ResolvedPublic

Description

If a user commits a revision, then I comment to point out some faults and the user commits another revision to fix it, it would be more convenient if I can receive a mail telling me the second commit.

Also, if I fix it my self, the user should receive a mail as well, but I'm not sure whether this is implemented currently.


Version: unspecified
Severity: enhancement

Details

Reference
bz24689

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:02 PM
bzimport set Reference to bz24689.
bzimport added a subscriber: Unknown Object (MLST).

r70588 does the commenters.

Do you want people who've set statuses, tags etc doing too?

Closing. Can reopen, or create a new one if you want status changers/taggers emailing too. Framework code has been added in already.

Also, if I fix it my self, the user should receive a mail as well, but I'm not
sure whether this is implemented currently.

It is (if the previous revision is provided in the comment).

(In reply to comment #2)

Closing. Can reopen, or create a new one if you want status changers/taggers
emailing too. Framework code has been added in already.

I'm not sure whether it's needed since status changers/taggers usually comment as well if the revision needs a followup.

I see boths points for getting notified and not when a revision gets OKed. So maybe it should be a preference?

(In reply to comment #5)

I see boths points for getting notified and not when a revision gets OKed. So
maybe it should be a preference?

Preferences suck, and I don't want to be notified on every OK that gets a followup.