In the BeforePageDisplay and SidebarBeforeOutput hooks, it calls ::getFeeds() to get the list of feeds to output URLs for in the head and sidebar respectively. But in doing so, it loads the entire feed content (->getFeedItems()), which is pretty slow given that all it needs is the feed names, which should be much faster.
Description
Description
Details
Details
Customize query in gerrit
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | CDanis | T266865 Very long response time on frwiki main page | |||
| Resolved | Legoktm | T266900 FeaturedFeeds loads all feed content just to output the feed URLs on the main page |
Event Timeline
Comment Actions
Change 651226 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/FeaturedFeeds@master] Don't load entire feed just to output the link to it
Comment Actions
Change 651209 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/FeaturedFeeds@wmf/1.36.0-wmf.22] Don't load entire feed just to output the link to it
Comment Actions
Change 651210 had a related patch set uploaded (by Reedy; owner: Legoktm):
[mediawiki/extensions/FeaturedFeeds@REL1_35] Don't load entire feed just to output the link to it
Comment Actions
Change 651226 merged by jenkins-bot:
[mediawiki/extensions/FeaturedFeeds@master] Don't load entire feed just to output the link to it
Comment Actions
Change 651209 merged by Legoktm:
[mediawiki/extensions/FeaturedFeeds@wmf/1.36.0-wmf.22] Don't load entire feed just to output the link to it
Comment Actions
Change 651210 merged by jenkins-bot:
[mediawiki/extensions/FeaturedFeeds@REL1_35] Don't load entire feed just to output the link to it
Comment Actions
Mentioned in SAL (#wikimedia-operations) [2020-12-21T17:56:49Z] <legoktm@deploy1001> Synchronized /srv/mediawiki-staging/php-1.36.0-wmf.22/extensions/FeaturedFeeds/includes/FeaturedFeeds.php: Don't load entire feed just to output the link to it (T266900) (duration: 01m 01s)