Page MenuHomePhabricator

Showing Other navigation and ⧼global-links-menu⧽ in using HasSomeColours skin.
Closed, ResolvedPublic

Description

Hi,

I setup media wiki on the my side and install skin https://www.mediawiki.org/wiki/Skin:HasSomeColours .

By the way, I can see "Other navigation" and "⧼global-links-menu⧽" on the left top of main page.

I checked you add it by https://github.com/wikimedia/mediawiki-skins-HasSomeColours/commit/1a7017544c039c4fca53045ce909f820ea79a7a5#diff-1a490f08504158838befaa816ee8d5c08dff9e694d5a568ce4b0a4398dcc563e

I am not sure it would a bug because it is first time use.

Can you explain how to fix it in my side?

Event Timeline

Aklapper removed a project: Gerrit.
Aklapper added a subscriber: Isarra.

Hi @Afewgoodman, thanks for taking the time to report this and welcome to Wikimedia Phabricator!
Please always follow https://www.mediawiki.org/wiki/How_to_report_a_bug and provide:

  • a clear and complete list of exact steps to reproduce the situation, step by step, so that nobody needs to guess or interpret how you performed each step,
  • what happens after performing these steps to reproduce,
  • what you expected to happen instead,
  • a full link to a web address where the issue can be seen (if public),
  • your exact MediaWiki version (if it is not on a Wikimedia website) which is shown on Special:Version,
  • the exact version of the skin.

Thanks. Also removing assignee as it is up to each person what they plan to [not] work on.

Aklapper changed the task status from Open to Stalled.Nov 6 2020, 9:07 AM
Aklapper added a project: HasSomeColours.

The global links menu ([[MediaWiki:Global-links-menu]]) is supposed to show up only when that MediaWiki: message has been defined with some content; by default the message itself isn't even defined (because it's used across many skins, so defining it in only one skin would likely cause some unexpected side-effects). As intended, after installing the skin, the global links menu does not show up unless explicitly confirmed; tested on MediaWiki 1.35.0 and the git master version of the HasSomeColours skin as of a few minutes ago.

Hi ashley,

Many thanks for explanation.

I am using MediaWiki 1.35.1.

I did not go through any sequence to comfirm it.

How can I do it? Can you please let me know?

BR.

2020년 11월 6일 (금) 오후 7:44, ashley <no-reply@phabricator.wikimedia.org>님이 작성:

ashley added a comment. View Task
https://phabricator.wikimedia.org/T267386

The global links menu ([[MediaWiki:Global-links-menu]]) is supposed to
show up only when that MediaWiki: message has been defined with some
content; by default the message itself isn't even defined (because it's
used across many skins, so defining it in only one skin would likely cause
some unexpected side-effects). As intended, after installing the skin, the
global links menu does *not* show up unless explicitly confirmed; tested
on MediaWiki 1.35.0 and the git master version of the HasSomeColours skin
as of a few minutes ago.

*TASK DETAIL*
https://phabricator.wikimedia.org/T267386

*EMAIL PREFERENCES*
https://phabricator.wikimedia.org/settings/panel/emailpreferences/

*To: *ashley
*Cc: *ashley, Isarra, Aklapper, Afewgoodman

[@Afewgoodman: Please do not full-quote and please strip unneeded quoted lines, to keep things readable. Thanks.]

Hi
[ @Aklapper : I am sorry I read how to document and I will be careful more to comment or raise issue in here. Thanks. ]

Ashely,

I installed MediaWiki as following command. sudo git clone https://gerrit.wikimedia.org/r/mediawiki/core.git --branch REL1_35 /var/www/mediawiki

Can you please explain more how to remove global links in my side?

BR.

Can you please explain more how to remove global links in my side?

Sorry, there was a typo in my original comment, the "confirmed" should have been "configured". That's to say, the global links menu isn't showing up unless you created the on-wiki page, MediaWiki:Global-links-menu, which sets it up. If that page exists, try either deleting it or setting its content to - (just a single dash character and nothing else).

Change 650274 had a related patch set uploaded (by Isarra; owner: Isarra):
[mediawiki/skins/HasSomeColours@master] Use updated everything

https://gerrit.wikimedia.org/r/650274

Change 650274 merged by jenkins-bot:
[mediawiki/skins/HasSomeColours@master] Use updated everything

https://gerrit.wikimedia.org/r/650274

Okay, this should now be fixed, but the linked change requires mw 1.36 because I'm a dumbarse and forgot to separate the changes. That being said, if you're willing to hack the skin, you should be able to use just the updated includes/HasSomeColoursTemplate.php file with 1.35 and it'll work properly there, too.

I... think.

Isarra claimed this task.

Okay, this should actually be fixed, for real, for sure, now. Apparently I forgot to define one of the message strings and that was the actual problem. Or another problem. It looks like there may have been several things going on here...