Page MenuHomePhabricator

Drop default of revactor_timestamp
Closed, ResolvedPublic

Description

Part of T42626: Standardise type of timestamp database fields (MySQL) and T230428: Migrate tables.sql to abstract schema

  1. ALTERs to run: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/640322/4/maintenance/archives/patch-revactor_timestamp-drop-default.sql
  2. Where to run those changes: all.dblist
  3. When to run those changes: At any time
  4. If the schema change is backwards compatible: Yes
  5. If the schema change has been tested already on some of the test/beta wikis: Tested in beta cluster. @Ladsgroup queried production and nothing has the default value.
  6. if the data should be made available on the labs replicas and/or dumps: Yes, data in this table is public.

Schema change progress:

Event Timeline

Marostegui moved this task from Triage to Ready on the DBA board.
Marostegui added a subscriber: Marostegui.

@Ammarpad that link results in 404, would you mind checking it? (The gerrit patch URL also works for us!)

@Ammarpad that link results in 404, would you mind checking it? (The gerrit patch URL also works for us!)

We removed that file later. You can find it in here: https://gerrit.wikimedia.org/r/c/mediawiki/core/+/640322/4/maintenance/archives/patch-revactor_timestamp-drop-default.sql

Thanks - I am going to update the task with that link.

s6 codfw progress:

  • db2076 sanitarium master
  • db2087:s6
  • db2089:s6
  • db2095:s6 sanitarium
  • db2097:s6 dbstore
  • db2114 candidate master
  • db2117 dump/vslow
  • db2124
  • db2129 master
  • db2141 dbstore

Mentioned in SAL (#wikimedia-operations) [2021-01-20T12:49:47Z] <kormat@cumin1001> START - Cookbook sre.hosts.downtime for 1 day, 0:00:00 on db2087.codfw.wmnet with reason: Schema change T267767

Mentioned in SAL (#wikimedia-operations) [2021-01-20T12:49:51Z] <kormat@cumin1001> END (PASS) - Cookbook sre.hosts.downtime (exit_code=0) for 1 day, 0:00:00 on db2087.codfw.wmnet with reason: Schema change T267767

Kormat updated the task description. (Show Details)
Kormat updated the task description. (Show Details)
Kormat updated the task description. (Show Details)

All of codfw is now done.

s6 eqiad progress:

  • db1085 sanitarium master, api
  • db1088 depooled for decom
  • db1096:3316
  • db1098:3316
  • db1113:3316 dump,vslow
  • db1125:3316 sanitarium
  • db1131 master
  • db1139:3316 backup source
  • db1140:3316 backup source
  • db1155:3316 sanitarium
  • db1168 basic
  • db1173 api
  • dbstore1005

Mentioned in SAL (#wikimedia-operations) [2021-03-10T10:38:18Z] <kormat@cumin1001> START - Cookbook sre.hosts.downtime for 1:00:00 on db1168.eqiad.wmnet with reason: schema change T267767

Mentioned in SAL (#wikimedia-operations) [2021-03-10T10:38:24Z] <kormat@cumin1001> END (PASS) - Cookbook sre.hosts.downtime (exit_code=0) for 1:00:00 on db1168.eqiad.wmnet with reason: schema change T267767

Mentioned in SAL (#wikimedia-operations) [2021-03-10T10:38:37Z] <kormat@cumin1001> dbctl commit (dc=all): 'db1168 depooling: schema change T267767', diff saved to https://phabricator.wikimedia.org/P14722 and previous config saved to /var/cache/conftool/dbconfig/20210310-103836-kormat.json

Mentioned in SAL (#wikimedia-operations) [2021-03-10T10:40:42Z] <kormat@cumin1001> dbctl commit (dc=all): 'db1168 (re)pooling @ 25%: schema change T267767', diff saved to https://phabricator.wikimedia.org/P14723 and previous config saved to /var/cache/conftool/dbconfig/20210310-104042-kormat.json

Mentioned in SAL (#wikimedia-operations) [2021-03-10T10:55:46Z] <kormat@cumin1001> dbctl commit (dc=all): 'db1168 (re)pooling @ 50%: schema change T267767', diff saved to https://phabricator.wikimedia.org/P14725 and previous config saved to /var/cache/conftool/dbconfig/20210310-105545-kormat.json

Mentioned in SAL (#wikimedia-operations) [2021-03-10T11:10:50Z] <kormat@cumin1001> dbctl commit (dc=all): 'db1168 (re)pooling @ 75%: schema change T267767', diff saved to https://phabricator.wikimedia.org/P14727 and previous config saved to /var/cache/conftool/dbconfig/20210310-111049-kormat.json

Mentioned in SAL (#wikimedia-operations) [2021-03-10T11:25:53Z] <kormat@cumin1001> dbctl commit (dc=all): 'db1168 (re)pooling @ 100%: schema change T267767', diff saved to https://phabricator.wikimedia.org/P14730 and previous config saved to /var/cache/conftool/dbconfig/20210310-112553-kormat.json

s5 eqiad progress:

  • db1082 api, sanitarium master
  • db1096:3315
  • db1100 master
  • db1110 basic
  • db1113:3315 dump,vslow
  • db1124:3315 sanitarium
  • db1130 api
  • db1144:3315
  • db1145:3315 backup source
  • db1150:3315 backup source
  • db1154:3315 sanitarium
  • dbstore1003

s2 eqiad progress:

  • db1074 sanitarium master
  • db1076
  • db1105:3312
  • db1122 master
  • db1125:3312 sanitarium
  • db1129
  • db1146:3312
  • db1155:3312 sanitarium
  • db1170:3312
  • db1171:3312 backup source
  • dbstore1004

s7 eqiad progress:

  • db1079 sanitarium master
  • db1086 master
  • db1098:3317
  • db1101:3317
  • db1116:3317 backup source
  • db1125 sanitarium
  • db1127
  • db1136
  • db1155 sanitarium
  • db1170 dump,vslow
  • db1174
  • dbstore1003

s4 eqiad progress:

  • db1121 sanitarium master
  • db1125 sanitarium
  • db1138 master
  • db1141
  • db1142
  • db1143
  • db1144:3314
  • db1145:3314 backup source
  • db1146:3314
  • db1147
  • db1148
  • db1149
  • db1150:3314 backup source
  • db1155 sanitarium
  • db1160
  • dbstore1004

s8 eqiad progress:

  • db1087 sanitarium master
  • db1099:3318
  • db1101:3318
  • db1104 master
  • db1109
  • db1111
  • db1114
  • db1116:3318 backup source
  • db1124 sanitarium
  • db1126
  • db1154 sanitarium
  • db1172
  • dbstore1005

Mentioned in SAL (#wikimedia-operations) [2021-03-15T10:02:55Z] <kormat@cumin1001> START - Cookbook sre.hosts.downtime for 1:00:00 on db1114.eqiad.wmnet with reason: schema change T267767

Mentioned in SAL (#wikimedia-operations) [2021-03-15T10:03:02Z] <kormat@cumin1001> END (PASS) - Cookbook sre.hosts.downtime (exit_code=0) for 1:00:00 on db1114.eqiad.wmnet with reason: schema change T267767

Mentioned in SAL (#wikimedia-operations) [2021-03-15T10:03:37Z] <kormat@cumin1001> dbctl commit (dc=all): 'db1114 depooling: schema change T267767', diff saved to https://phabricator.wikimedia.org/P14835 and previous config saved to /var/cache/conftool/dbconfig/20210315-100337-kormat.json

Mentioned in SAL (#wikimedia-operations) [2021-03-15T10:11:45Z] <kormat@cumin1001> dbctl commit (dc=all): 'db1114 (re)pooling @ 50%: schema change T267767', diff saved to https://phabricator.wikimedia.org/P14836 and previous config saved to /var/cache/conftool/dbconfig/20210315-101143-kormat.json

Mentioned in SAL (#wikimedia-operations) [2021-03-15T10:26:49Z] <kormat@cumin1001> dbctl commit (dc=all): 'db1114 (re)pooling @ 100%: schema change T267767', diff saved to https://phabricator.wikimedia.org/P14838 and previous config saved to /var/cache/conftool/dbconfig/20210315-102648-kormat.json

s3 eqiad progress:

  • db1112 sanitarium master
  • db1123 master
  • db1124 sanitarium
  • db1154 sanitarium
  • db1157
  • db1166
  • db1171:3313 backup source
  • db1175
  • dbstore1004:3313
Kormat updated the task description. (Show Details)

s1 eqiad progress:

  • db1083 master
  • db1084 api
  • db1099:3311 recentchanges et al
  • db1105:3311 recentchanges et al
  • db1106:3311 sanitarium master
  • db1118 <none>
  • db1119 api
  • db1124:3311 sanitarium
  • db1134 api
  • db1135 api
  • db1139:3311 backup source
  • db1140:3311 backup source
  • db1154:3311 sanitarium
  • db1163 <none>
  • db1164 api
  • db1169 api
  • dbstore1003:3311

Status: Complete!