Page MenuHomePhabricator

Add 'Stock Information' field to thank you letter
Closed, ResolvedPublic

Description

Taken from T259173#6628884

LeanneS added a comment.Tue, Nov 17, 9:31 PM
Thank you @jgleeson! I just tested and the new field showed successfully in the receipt. Would it be possible to add in the Stock Description field to that first sentence as well? We use that field to indicate X number of shares of X stock were received. Stock thank you letters usually indicate that for tax purposes and including will make it clear to the donor that we received their stock transfer. Something like below would work:

Thank you for your one-time gift of <Stock Information> valued at $<Stock Value>.

Let me know if you have any questions, and thanks again!

Should be easy to pull in the additional field inline with this patch

Event Timeline

Thanks for this. If it's not a huge deal, we should try to get this in before the holidays. Let's talk in standup tomorrow.

Change 643094 had a related patch set uploaded (by Cstone; owner: Cstone):
[wikimedia/fundraising/crm@master] WIP: Add Description of Stock to thank you email.

https://gerrit.wikimedia.org/r/643094

Change 643094 merged by jenkins-bot:
[wikimedia/fundraising/crm@master] Add Description of Stock to thank you email.

https://gerrit.wikimedia.org/r/643094

@LeanneS we think this completes the stock task from last sprint T25917. can you confirm?

@DStrine Thanks! The stock info field shows up great in the new email. Looking further down the email, there is this sentence that shows the Total Amount field: For your records: Your donation, number X, on 2020-11-24 was USD X.00. Is it possible to update (or remove) to prevent confusion?

@DStrine Just want to ping on my previous note. Would it be possible to remove or update that sentence lower down in the email so we can begin using the new stock TY email? Thanks very much!

I didn't see the last comment. We'll have to look at this again.

@LeanneS @CDenes_WMF and @jgleeson. I heard from @CDenes_WMF the string that designates stock value string has english in it and would not be translate-able. This might need some review and collaboration or stock sections can't be used in non-english TY emails.

Thanks @DStrine. Most, if not all, stock donors are U.S. based so I don't think a translated TY email would come up much. I think @CDenes_WMF's solution of removing the stock description for non English versions would work, and we can always send a manual TY if that pops up.

@LeanneS that means that the non US stock donors will essentially get a fairly generic TY email. Would you rather just send them all in english only? That's essentially what you have been doing by hand, right?

@DStrine That's right. I just took a look and all donors in the past 4 years besides one have been U.S. based, so I think it would be fine to do English only. If a non-U.S. stock donation pops up, we can do by hand.

Thank you @DStrine and @Cstone! Let me know if you have any questions.

Hi all! Recording for good documentation's sake that for non-English versions of the Thank you email, the translation will drop the "description of stock" variable, and we will be translating the following, simplified source text instead:

"Thank you for your one-time stock gift of {{ (currency ~ " " ~ stock_value) | l10n_currency(locale) }}. "

Camille

Whoops sorry yall, just got caught up on the conversation prior. Please disregard my comment above --

I will instead take out entirely the stock sentence from all non-English versions of the TY email. Thank you for hashing out!

Change 644951 had a related patch set uploaded (by Cstone; owner: Cstone):
[wikimedia/fundraising/crm@master] Remove the for your record section when it is a stock.

https://gerrit.wikimedia.org/r/644951

DStrine triaged this task as High priority.Dec 3 2020, 7:21 PM

Change 644951 merged by jenkins-bot:
[wikimedia/fundraising/crm@master] Remove the for your record section when it is a stock.

https://gerrit.wikimedia.org/r/644951

@LeanneS this looks to be done to your liking. Please let us know what you think.

@DStrine Thanks! I just reviewed and it looks like we're almost set, but the whole tax exempt section was removed. I think that might be needed for tax purposes right?

@Cstone and @LeanneS can the two of you get on a call together and lock in the text that is needed? It might be easier to have a tighter loop on edits and QA on this.

Change 647062 had a related patch set uploaded (by Cstone; owner: Cstone):
[wikimedia/fundraising/crm@master] Add donation record line back in for stock thank yous.

https://gerrit.wikimedia.org/r/647062

Change 647062 merged by jenkins-bot:
[wikimedia/fundraising/crm@master] Add donation record line back in for stock thank yous.

https://gerrit.wikimedia.org/r/647062

@Cstone @MDemosWMF and I reviewed the latest deployment and looks like we're all set! Thanks for your help!