Page MenuHomePhabricator

Deprecate passing a selector to OO.ui.infuse
Closed, ResolvedPublic

Description

Since T154476, OO.ui.Element.static.infuse no longer accepts an ID.

However, removing this accidentally allowed a selector to be passed. Since OO.ui.infuse documentation still allows passing a string, passing a selector appears to be a legitimate use case, even though it is actually unsupported.

  • Emit a deprecation warning if a string is passed to OO.ui.infuse
  • Fix callers that pass a selector

Event Timeline

Change 644617 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/EntitySchema@master] Fix calls to OO.ui.infuse

https://gerrit.wikimedia.org/r/644617

Change 644618 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/core@master] Don't pass stirngs to OO.ui.infuse

https://gerrit.wikimedia.org/r/644618

Change 644619 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[oojs/ui@master] Deprecate passing a string to OO.ui.infuse

https://gerrit.wikimedia.org/r/644619

Change 644618 abandoned by Bartosz Dziewoński:
[mediawiki/core@master] Don't pass strings to OO.ui.infuse

Reason:
Duplicate of https://gerrit.wikimedia.org/r/c/mediawiki/core/ /643603

https://gerrit.wikimedia.org/r/644618

Change 644619 merged by jenkins-bot:
[oojs/ui@master] Deprecate passing a string to OO.ui.infuse

https://gerrit.wikimedia.org/r/644619

Change 645179 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/core@master] Update OOUI to v0.41.0

https://gerrit.wikimedia.org/r/645179

Change 645179 merged by jenkins-bot:
[mediawiki/core@master] Update OOUI to v0.41.0

https://gerrit.wikimedia.org/r/645179

Change 644617 merged by jenkins-bot:
[mediawiki/extensions/EntitySchema@master] Fix calls to OO.ui.infuse

https://gerrit.wikimedia.org/r/644617

matmarex added a subscriber: matmarex.

All done?