Page MenuHomePhabricator

input type=datetimepicker and input type=datetime break QueryForm (Fatal Error)
Closed, ResolvedPublic

Description

Using the datetimepicker or datetime input types break my query forms.

When using datetimepicker calling Run query:MYQUERY results in

[X8jC200g73hl3eTQnwjEIQAAAAA] /MYWIKI/index.php/Spezial:Abfrage_ausf%C3%BChren/Arbeitsauftr%C3%A4ge OOUI\Exception from line 31 of /home/www/sites/MYIPmediawiki-1.31.1/vendor/oojs/oojs-ui/php/Theme.php: OOUI\Theme::singleton was called with no singleton theme set.

Backtrace:

#0 /home/www/sites/MYIPmediawiki-1.31.1/vendor/oojs/oojs-ui/php/Element.php(241): OOUI\Theme::singleton()
#1 /home/www/sites/MYIPmediawiki-1.31.1/extensions/PageForms/includes/forminputs/PF_DateTimePicker.php(64): OOUI\Element->toString()
#2 /home/www/sites/MYIPmediawiki-1.31.1/extensions/PageForms/includes/PF_FormPrinter.php(1910): PFDateTimePicker->getHtmlText()
#3 /home/www/sites/MYIPmediawiki-1.31.1/extensions/PageForms/includes/PF_FormPrinter.php(1300): PFFormPrinter->formFieldHTML(PFFormField, NULL)
#4 /home/www/sites/MYIPmediawiki-1.31.1/includes/StubObject.php(112): PFFormPrinter->formHTML(string, boolean, boolean, integer, NULL, NULL, NULL, boolean, boolean)
#5 /home/www/sites/MYIPmediawiki-1.31.1/includes/StubObject.php(138): StubObject->_call(string, array)
#6 /home/www/sites/MYIPmediawiki-1.31.1/extensions/PageForms/specials/PF_RunQuery.php(86): StubObject->__call(string, array)
#7 /home/www/sites/MYIPmediawiki-1.31.1/extensions/PageForms/specials/PF_RunQuery.php(26): PFRunQuery->printPage(string, boolean)
#8 /home/www/sites/MYIPmediawiki-1.31.1/includes/specialpage/SpecialPage.php(522): PFRunQuery->execute(string)
#9 /home/www/sites/MYIPmediawiki-1.31.1/includes/specialpage/SpecialPageFactory.php(568): SpecialPage->run(string)
#10 /home/www/sites/MYIPmediawiki-1.31.1/includes/MediaWiki.php(288): SpecialPageFactory::executePath(Title, RequestContext)
#11 /home/www/sites/MYIPmediawiki-1.31.1/includes/MediaWiki.php(861): MediaWiki->performRequest()
#12 /home/www/sites/MYIPmediawiki-1.31.1/includes/MediaWiki.php(524): MediaWiki->main()
#13 /home/www/sites/MYIPmediawiki-1.31.1/index.php(42): MediaWiki->run()
#14 {main}

When using datetime Run query:MYQUERY loads but when executing the query it breaks with

[X8jFIbfOJPGXGSrEsnYwHgAAAB8] /MYWIKI/index.php/Spezial:Abfrage_ausf%C3%BChren/Arbeitsauftr%C3%A4ge?title=Spezial%3AAbfrage_ausf%C3%BChren%2FArbeitsauftr%C3%A4ge&pfRunQueryFormName=Arbeitsauftr%C3%A4ge&Arbeitsauftr%C3%A4ge%5BErstellt+von%5D=&Arbeitsauftr%C3%A4ge%5Bmap_field%5D%5BErstellt+von%5D=true&Arbeitsauftr%C3%A4ge%5BErledigen+von%5D=&Arbeitsauftr%C3%A4ge%5Bmap_field%5D%5BErledigen+von%5D=true&Arbeitsauftr%C3%A4ge%5BF%C3%BCr+Bereich%5D=&Arbeitsauftr%C3%A4ge%5BNachalarmierung+F%C3%BChrungskraft+Name%5D%5Bis_list%5D=1&Arbeitsauftr%C3%A4ge%5BGeh%C3%B6rt+zu+AKS%5D=&Arbeitsauftr%C3%A4ge%5BHat+Priorit%C3%A4t%5D=&Arbeitsauftr%C3%A4ge%5BJobtyp%5D=&Arbeitsauftr%C3%A4ge%5BHat+Fortschritt%5D=&Arbeitsauftr%C3%A4ge%5BZeitraum+Beginn%5D%5Bday%5D=1&Arbeitsauftr%C3%A4ge%5BZeitraum+Beginn%5D%5Bmonth%5D=01&Arbeitsauftr%C3%A4ge%5BZeitraum+Beginn%5D%5Byear%5D=2020&Arbeitsauftr%C3%A4ge%5BZeitraum+Beginn%5D%5Bhour%5D=0&Arbeitsauftr%C3%A4ge%5BZeitraum+Beginn%5D%5Bminute%5D=0&Arbeitsauftr%C3%A4ge%5BZeitraum+Beginn%5D%5Bsecond%5D=0&Arbeitsauftr%C3%A4ge%5BZeitraum+Beginn%5D%5Bampm24h%5D=AM&Arbeitsauftr%C3%A4ge%5BZeitraum+Ende%5D%5Bday%5D=&Arbeitsauftr%C3%A4ge%5BZeitraum+Ende%5D%5Bmonth%5D=&Arbeitsauftr%C3%A4ge%5BZeitraum+Ende%5D%5Byear%5D=&Arbeitsauftr%C3%A4ge%5BZeitraum+Ende%5D%5Bhour%5D=&Arbeitsauftr%C3%A4ge%5BZeitraum+Ende%5D%5Bminute%5D=&Arbeitsauftr%C3%A4ge%5BZeitraum+Ende%5D%5Bsecond%5D=00&Arbeitsauftr%C3%A4ge%5BZeitraum+Ende%5D%5Bampm24h%5D=&Arbeitsauftr%C3%A4ge%5BVollst%C3%A4ndig+im+Zeitraum%5D%5Bis_checkbox%5D=true&Arbeitsauftr%C3%A4ge%5BIst+wiederkehrend%5D%5Bis_checkbox%5D=true&pf_free_text=&wpRunQuery=Run+query Exception from line 73 of /home/www/sites/MYIPmediawiki-1.31.1/extensions/PageForms/includes/forminputs/PF_DateTimeInput.php: DateTime::__construct(): Failed to parse time string (2020/01/01 00:00:00 AM) at position 20 (A): The timezone could not be found in the database

Backtrace:

#0 /home/www/sites/MYIPmediawiki-1.31.1/extensions/PageForms/includes/forminputs/PF_DateTimeInput.php(73): DateTime->__construct(string)
#1 /home/www/sites/MYIPmediawiki-1.31.1/extensions/PageForms/includes/forminputs/PF_DateTimeInput.php(145): PFDateTimeInput::getHTML(string, string, boolean, boolean, array)
#2 /home/www/sites/MYIPmediawiki-1.31.1/extensions/PageForms/includes/PF_FormPrinter.php(1910): PFDateTimeInput->getHtmlText()
#3 /home/www/sites/MYIPmediawiki-1.31.1/extensions/PageForms/includes/PF_FormPrinter.php(1300): PFFormPrinter->formFieldHTML(PFFormField, string)
#4 /home/www/sites/MYIPmediawiki-1.31.1/includes/StubObject.php(112): PFFormPrinter->formHTML(string, boolean, boolean, integer, NULL, NULL, NULL, boolean, boolean)
#5 /home/www/sites/MYIPmediawiki-1.31.1/includes/StubObject.php(138): StubObject->_call(string, array)
#6 /home/www/sites/MYIPmediawiki-1.31.1/extensions/PageForms/specials/PF_RunQuery.php(86): StubObject->__call(string, array)
#7 /home/www/sites/MYIPmediawiki-1.31.1/extensions/PageForms/specials/PF_RunQuery.php(26): PFRunQuery->printPage(string, boolean)
#8 /home/www/sites/MYIPmediawiki-1.31.1/includes/specialpage/SpecialPage.php(522): PFRunQuery->execute(string)
#9 /home/www/sites/MYIPmediawiki-1.31.1/includes/specialpage/SpecialPageFactory.php(568): SpecialPage->run(string)
#10 /home/www/sites/MYIPmediawiki-1.31.1/includes/MediaWiki.php(288): SpecialPageFactory::executePath(Title, RequestContext)
#11 /home/www/sites/MYIPmediawiki-1.31.1/includes/MediaWiki.php(861): MediaWiki->performRequest()
#12 /home/www/sites/MYIPmediawiki-1.31.1/includes/MediaWiki.php(524): MediaWiki->main()
#13 /home/www/sites/MYIPmediawiki-1.31.1/index.php(42): MediaWiki->run()
#14 {main}

This depends on what is in the datetime fields and might be another story.

Version

MW 1.31.1
SMW 3.2.1
SCQ 2.1.0
SRF 3.2.0
PF 5.0
Maps 7.20.1
SemanticDrilldown 2.1

Event Timeline

Aklapper edited subscribers, added: Yaron_Koren; removed: MediaWiki-extensions-Page_Forms.

Hi, please do not add project tags as subscribers and do not assign tasks to people without their consent - thanks a lot! :)

Change 644980 had a related patch set uploaded (by Yaron Koren; owner: Yaron Koren):
[mediawiki/extensions/PageForms@master] Fix date(time)picker handling in Special:RunQuery

https://gerrit.wikimedia.org/r/644980

Change 644980 merged by jenkins-bot:
[mediawiki/extensions/PageForms@master] Fix date(time)picker handling in Special:RunQuery

https://gerrit.wikimedia.org/r/644980

Yaron_Koren claimed this task.

Sorry about that! I think this is fixed now.

Sorry about that! I think this is fixed now.

It works , Thanks