Page MenuHomePhabricator

New table scroll slight visual "tweaks"?
Closed, ResolvedPublic

Description

See https://en.wikipedia.org/wiki/List_of_play-by-mail_games

  1. When displaying a standard wiki table with caption, there is a border around the caption that I'm pretty sure was not there before. I don't think the bar should cause that border.
  2. I think the "scroll" bar probably should extend to the top of the tbody rather than the top of the table. Or at least the top of the highest headers rather than the caption. The bar causes otherwise good whitespace to be a sad grayspace extending past what looks to be the visible table, until you realize the caption is there.
  3. The "arrow" on the bar indicating scrolley isn't in the viewport on tall tables at all times and probably should be.
  4. Table caption content might stand to be centered in the viewport. I can take this one or leave it. Minerva aligns this text left on mobile resolutions, so that might be preferable in general?

The image actually captures every issue.

Event Timeline

  1. When displaying a standard wiki table with caption, there is a border around the caption that I'm pretty sure was not there before. I don't think the bar should cause that border.
  2. I think the "scroll" bar probably should extend to the top of the tbody rather than the top of the table. Or at least the top of the highest headers rather than the caption. The bar causes otherwise good whitespace to be a sad grayspace extending past what looks to be the visible table, until you realize the caption is there.

2 isn't possible, but this definitely makes a good argument for 1.

  1. The "arrow" on the bar indicating scrolley isn't in the viewport on tall tables at all times and probably should be.

Per 1-2, yeah, just gonna kill that for now too, I think. Maybe bring it back as a popout toggle later if I ever figure out how to pop them out. And ideally we'd just have a sticky scrollbar (on desktop) to indicate the scrollability better without anything weird anyway, but... this is apparently very beyond my skill.

Table caption content might stand to be centered in the viewport. I can take this one or leave it. Minerva aligns this text left on mobile resolutions, so that might be preferable in general?

Don't know how to do this either, so... yeah, let's just copy minerva.

Change 649116 had a related patch set uploaded (by Isarra; owner: Isarra):
[mediawiki/skins/Timeless@master] Redo scrolling tables visuals to be less bad

https://gerrit.wikimedia.org/r/649116

Okay maybe 2 is possible but it scares the bejeezers out of me so I'm just gonna pretend it isn't.

Change 649116 merged by jenkins-bot:
[mediawiki/skins/Timeless@master] Redo scrolling tables visuals to be less bad

https://gerrit.wikimedia.org/r/649116

Hmm, we might be able to change the position of the shadows, and do some horrible hacks to the caption to get it to cooperate after all...

Change 649749 had a related patch set uploaded (by Isarra; owner: Isarra):
[mediawiki/skins/Timeless@master] Limit table caption size to content width and don't scroll

https://gerrit.wikimedia.org/r/649749

Change 649749 merged by jenkins-bot:
[mediawiki/skins/Timeless@master] Limit table caption size to content width and don't scroll

https://gerrit.wikimedia.org/r/649749

Isarra claimed this task.

Okay done all the things, or similar, or something, thanks! Very helpful!