Page MenuHomePhabricator

"Edit" link on old revisions of a page links to the latest revision instead of the revision being viewed
Closed, ResolvedPublic

Description

When viewing an old revision of a page, clicking "edit" normally brings you to a URL like action=edit&oldid=XXXXX. For certain revisions of certain pages, the "edit" link does not include the oldid parameter. For example:

Clicking edit brings you to:

It should bring you to:

Event Timeline

It's not just that really old page, the same issue happens on this test revision:

I was able to bisect this to https://gerrit.wikimedia.org/r/c/mediawiki/core/+/646818

@Pchelolo Can you please have a look? This is either a regression in this week's or last week's train.

I cannot reproduce this. The 'edit' link works correctly (at least for me). Can you reproduce it while logged out?

For certain revisions of certain pages

Ok, I missed this clause. I reproduced it when I clicked the link for the second time. For the first time, it worked correctly.
But my hunch is that this is how it used to work already.

Change 650114 had a related patch set uploaded (by Ppchelko; owner: Ppchelko):
[mediawiki/core@master] Article: view from old revision cache - set correct revId.

https://gerrit.wikimedia.org/r/650114

Change 649923 had a related patch set uploaded (by Ppchelko; owner: Ppchelko):
[mediawiki/core@wmf/1.36.0-wmf.22] Article: view from old revision cache - set correct revId.

https://gerrit.wikimedia.org/r/649923

Change 650114 merged by jenkins-bot:
[mediawiki/core@master] Article: view from old revision cache - set correct revId.

https://gerrit.wikimedia.org/r/650114

Change 649923 merged by jenkins-bot:
[mediawiki/core@wmf/1.36.0-wmf.22] Article: view from old revision cache - set correct revId.

https://gerrit.wikimedia.org/r/649923

Pchelolo claimed this task.
Pchelolo moved this task from Backlog to Done on the Platform Team Workboards (Green) board.

Mentioned in SAL (#wikimedia-operations) [2020-12-17T19:39:41Z] <urbanecm@deploy1001> Synchronized php-1.36.0-wmf.22/includes/page/Article.php: rMW6c97eede7b02: Article: view from old revision cache - set correct revId (T270361) (duration: 01m 04s)