Page MenuHomePhabricator
Create Task
Maniphest T270872

Subpages class treated differently in Minerva/Mobile
Closed, DuplicatePublic
Actions

Description

I recently noticed that the CSS class subpages is treated differently in the Minerva skin. In Vector, Monobook, Timeless etc., span.subpages is getting a display:block, while in Minerva it does not. This causes problems when there are two span elements within the contentSub / minerva__subtitle of a page, as it happens in category subpages on dewiki, such as this one. If subpages is not formatted as a block element, the two lines will stick together without line break or spacing in between. We are now explicitly forcing display:block via Minerva.css and Mobile.css, but I feel like there should be a more obvious solution. Is there any reason why Minerva is treating subpages differently?

Maybe related to T256932.

Related Objects

Event Timeline

XanonymusX created this task.Dec 28 2020, 2:43 PM
Restricted Application added subscribers: Masumrezarock100, Aklapper. · View Herald TranscriptDec 28 2020, 2:43 PM
XanonymusX updated the task description. (Show Details)Dec 28 2020, 2:46 PM
Jdlrobson edited projects, added MediaWiki-Core-Skin-Architecture; removed MobileFrontend (MobileFrontend and MinervaNeue architecture).May 4 2021, 9:17 PM
Jdlrobson moved this task from Backlog to Milestone: More flexibility in article heading area (subpages, descriptions) on the MediaWiki-Core-Skin-Architecture board.May 5 2021, 7:15 PM
Jdlrobson subscribed.Aug 24 2021, 12:32 AM

@XanonymusX is there a more up-to-date link that demonstratess this issue? I think I understand it but want to make sure.

Right now I am leaning towards recommending span.subpages should be changed to a DIV element in this particular case since this seems like a sensible default given how it is used:
https://gerrit.wikimedia.org/g/mediawiki/core/+/3c5ef86bc0d82056929ada2287b4208a69420459/includes/skins/Skin.php#2563

XanonymusX added a comment.Aug 24 2021, 11:00 AM

The linked page is still the relevant use case. To see the issue, you just need to be logged in and get rid of span.subpages {display: block;} in Minerva.css and Mobile.css, which is our temporary fix.

Jdlrobson added a comment.Aug 24 2021, 3:41 PM

Do I need to enable a gadget? Looking fine to me even when that rule is removed:

Screen Shot 2021-08-24 at 8.41.27 AM.png (676×2 px, 151 KB)

XanonymusX added a comment.Aug 24 2021, 6:19 PM

Hm, so you basically do not see the element mw-fr-category-oldreviewed. I thought logged-in users would see it generally, but since it comes from FlaggedRevs, I suppose you need reviewer rights in order to see it.

This is what it looked like:

Screenshot Category Subtitle.jpg (592×1 px, 147 KB)

This is what the fix does:

Screenshot Category Subtitle Fix.jpg (616×1 px, 147 KB)

Jdlrobson moved this task from Milestone: More flexibility in article heading area (subpages, descriptions) to It's not a priority on the MediaWiki-Core-Skin-Architecture board.Oct 12 2021, 6:25 PM
Jdlrobson moved this task from It's not a priority to Milestone: More flexibility in article heading area (subpages, descriptions) on the MediaWiki-Core-Skin-Architecture board.
Jdlrobson added a project: Web-Team-Backlog (Needs Prioritization (Tech)).Dec 7 2021, 2:37 AM
Jdlrobson moved this task from Backlog to Unused on the Web-Team-Backlog (Needs Prioritization (Tech)) board.
Jdlrobson triaged this task as Low priority.Dec 9 2021, 7:42 PM

Ahh FlaggedRevisions.. I see. Yeh that extension is not maintained, so I can imagine it's restricted to only places it needs to show. Thanks for that context.

Jdlrobson removed a project: Web-Team-Backlog (Needs Prioritization (Tech)).Jan 7 2022, 4:56 PM
hgzh subscribed.Mar 12 2024, 9:16 AM

I think this got fixed by https://gerrit.wikimedia.org/r/c/mediawiki/core/+/833413, right?

Jdlrobson added a comment.Mar 12 2024, 11:15 PM

Yes! thanks for connecting these!

Jdlrobson closed this task as a duplicate of T317452: [Regression] Breadcrumb links and redirect indicators are abutting.Mar 12 2024, 11:15 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits