remove magic coding comments
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Xqt
	Dec 30 2020, 4:10 PM

Description

Introduction

Magic coding comments like
# -*- coding: utf-8 -*-
is for Python 2 whereas Python 3 uses utf-8 by default and can be omitted.

What to do?

Remove all magic coding comments from all Python script files. They can be found here.

Details

	Subject	Repo	Branch	Lines +/-
	Removed remove magic coding comments # -- coding: utf-8 --	pywikibot/core	master	+0 -220

Customize query in gerrit

Related Objects

Mentioned In: rPWBC2dd91c5f0537: Removed remove magic coding comments # -*- coding: utf-8 -*-

Event Timeline

Xqt created this task.Dec 30 2020, 4:10 PM

Restricted Application added subscribers: pywikibot-bugs-list, Aklapper. · View Herald TranscriptDec 30 2020, 4:10 PM

Xqt triaged this task as Low priority.Dec 30 2020, 4:11 PM

TemporalPincher claimed this task.Dec 31 2020, 8:20 AM

TemporalPincher subscribed.

@TemporalPincher: are you still working on it?

@TemporalPincher: I removd you from assignee of this task. Feel free to claim it again if you are going to work on it. But others may also claim this task.

Bharatkhatri351 claimed this task.Jan 22 2021, 1:00 PM

hey
i have to remove this comment
but when i removed this comment there is one blank line remaining at this place of comment

is it okay or i have to remove blank line too.......

In T270946#6768801, @Bharatkhatri351 wrote:

is it okay or i have to remove blank line too.......

You have to remove this blank line too.

Change 657818 had a related patch set uploaded (by Bharatkhatri; owner: Bharatkhatri):
[pywikibot/core@master] Removed remove magic coding comments # -*- coding: utf-8 -*-

https://gerrit.wikimedia.org/r/657818

gerritbot added a project: Patch-For-Review.Jan 22 2021, 2:16 PM

Thanks a lot

Change 657818 merged by jenkins-bot:
[pywikibot/core@master] Removed remove magic coding comments # -*- coding: utf-8 -*-

https://gerrit.wikimedia.org/r/657818

Bharatkhatri351 mentioned this in rPWBC2dd91c5f0537: Removed remove magic coding comments # -*- coding: utf-8 -*-.Jan 22 2021, 7:34 PM

Maintenance_bot removed a project: Patch-For-Review.Jan 22 2021, 8:11 PM