Page MenuHomePhabricator
Create Task
Maniphest T271198

Visual diff does not display preformatted text correctly
Closed, ResolvedPublic
Actions

Description

When adding new blocks of preformatted text (in a <pre>), the visual diff displays line breaks as ↵ symbols rather than as actual line breaks.

https://test.wikipedia.org/w/index.php?title=User:Catrope&type=revision&diff=462981&oldid=462980&diffmode=visual

Screenshot from 2021-01-04 17-56-21.png (163×582 px, 24 KB)

Details

SubjectRepoBranchLines +/-
Update VE core submodule to master (ad72a726d)mediawiki/extensions/VisualEditormaster+1 -1
Don't do whitespace substitutions in hasSignificantWhitespace nodesVisualEditor/VisualEditormaster+25 -2
Customize query in gerrit

Related Objects

Event Timeline

• Catrope created this task.Jan 5 2021, 10:29 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 5 2021, 10:29 AM
ppelberg moved this task from To Triage to Triaged on the VisualEditor board.Jan 12 2021, 4:40 PM
gerritbot added a comment.Jan 12 2021, 10:16 PM

Change 655788 had a related patch set uploaded (by Esanders; owner: Esanders):
[VisualEditor/VisualEditor@master] Don't do whitespace substitutions in hasSignificantWhitespace nodes

https://gerrit.wikimedia.org/r/655788

gerritbot added a project: Patch-For-Review.Jan 12 2021, 10:16 PM
matmarex added a project: Editing-team (Kanban Board).Jan 13 2021, 5:01 PM
matmarex moved this task from Incoming to Code Review on the Editing-team (Kanban Board) board.
gerritbot added a comment.Jan 13 2021, 5:04 PM

Change 655788 merged by jenkins-bot:
[VisualEditor/VisualEditor@master] Don't do whitespace substitutions in hasSignificantWhitespace nodes

https://gerrit.wikimedia.org/r/655788

gerritbot added a comment.Jan 13 2021, 5:08 PM

Change 655922 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (ad72a726d)

https://gerrit.wikimedia.org/r/655922

gerritbot added a comment.Jan 13 2021, 5:38 PM

Change 655922 merged by jenkins-bot:
[mediawiki/extensions/VisualEditor@master] Update VE core submodule to master (ad72a726d)

https://gerrit.wikimedia.org/r/655922

matmarex moved this task from Code Review to Ready for Sign Off on the Editing-team (Kanban Board) board.Jan 13 2021, 6:00 PM
matmarex edited projects, added Skipped QA; removed Patch-For-Review.
ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.27; 2021-01-19).Jan 13 2021, 6:00 PM
ppelberg closed this task as Resolved.Jan 16 2021, 4:10 AM
ppelberg claimed this task.
Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptJan 16 2021, 4:10 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits