Maniphest T273529

MediaWiki-Docker installation is broken if MW_SCRIPT_PATH conflicts with hardcoded /w for various paths
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	brennen
	Feb 1 2021, 8:44 PM

Tags

Referenced Files

None

Subscribers

Jdforrester-WMF

Description

@Krinkle reported a situation where:

There's an MW_SCRIPT_PATH that happens to be set in the environment (for use with mw-docker-dev).
docker-compose takes values from the environment in preference to those defined in .env
In MediaWiki-Docker's docker-compose setup, we pass MW_SCRIPT_PATH to the installer, but hardcode /w a bunch of other places.

This situation should probably be reconciled. It probably requires some (hopefully minor) changes to dev-images/dockerfiles/stretch/install.sh, as well as (maybe trickier) the WORKDIR for several images.

I _think_ it seems like the path here should either be fully configurable, or just not give the illusion of configurability with MW_SCRIPT_PATH, but this might need more thought.

Details

	Subject	Repo	Branch	Lines +/-
	MediaWiki-Docker: Remove injection of MW_SCRIPT_PATH	mediawiki/core	master	+4 -3

Customize query in gerrit

Related Objects

Mentioned In: T283886: Fresh check-out of mediawiki-docker has paths pointing to /mediawiki/ despite /w/ being configured in docker-compose

Event Timeline

brennen created this task.Feb 1 2021, 8:44 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 1 2021, 8:44 PM

Jdforrester-WMF mentioned this in T283886: Fresh check-out of mediawiki-docker has paths pointing to /mediawiki/ despite /w/ being configured in docker-compose.May 27 2021, 10:05 PM

Jdforrester-WMF merged a task: T283886: Fresh check-out of mediawiki-docker has paths pointing to /mediawiki/ despite /w/ being configured in docker-compose.

Jdforrester-WMF subscribed.

Change 720409 had a related patch set uploaded (by Krinkle; author: Krinkle):

[mediawiki/core@master] MediaWiki-Docker: Remove injection of MW_SCRIPT_PATH

https://gerrit.wikimedia.org/r/720409

gerritbot added a project: Patch-For-Review.Sep 10 2021, 10:39 PM

Change 720409 merged by jenkins-bot:

[mediawiki/core@master] MediaWiki-Docker: Remove injection of MW_SCRIPT_PATH

https://gerrit.wikimedia.org/r/720409

Maintenance_bot removed a project: Patch-For-Review.Sep 13 2021, 8:10 PM

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.23; 2021-09-13).Sep 13 2021, 9:00 PM

Krinkle closed this task as Resolved.Sep 26 2021, 8:29 PM

Krinkle claimed this task.