Page MenuHomePhabricator
Create Task
Maniphest T273904

Default value of GEHomepageManualAssignmentMentorsList is null, while MentorManager only recognizes '' as "no page provided"
Closed, ResolvedPublic
Actions

Description

While working on T273776: Scale: ability to deploy without mentorship module, I realized that the default value of wgGEHomepageManualAssignmentMentorsList is null, while MentorPageMentorManager::getManuallyAssignedMentorsPage only recognizes '' as "no page provided", resulting in warnings logged on a default setup.

Let's make MentorPageMentorManager::getManuallyAssignedMentorsPage accept null as well.

Details

SubjectRepoBranchLines +/-
GEHomepage(Manual)MentorsList should consistently use null for "no list"mediawiki/extensions/GrowthExperimentsmaster+32 -23
MentorManager::getManuallyAssignedMentorsPage should recognize null as 'no page provided'mediawiki/extensions/GrowthExperimentsmaster+4 -1
Customize query in gerrit

Related Objects

Event Timeline

Urbanecm_WMF created this task.Feb 4 2021, 4:58 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 4 2021, 4:58 PM
Urbanecm_WMF added a project: Growth-Team (Sprint 0 (Growth Team)).Feb 4 2021, 4:58 PM
gerritbot added a comment.Feb 4 2021, 4:59 PM

Change 661751 had a related patch set uploaded (by Urbanecm; owner: Urbanecm):
[mediawiki/extensions/GrowthExperiments@master] MentorManager::getManuallyAssignedMentorsPage should recognize null as 'no page provided'

https://gerrit.wikimedia.org/r/661751

gerritbot added a project: Patch-For-Review.Feb 4 2021, 4:59 PM
Urbanecm_WMF moved this task from Incoming to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.Feb 4 2021, 4:59 PM
Urbanecm_WMF moved this task from Backlog to In review on the User-Urbanecm_WMF (Engineering) board.Feb 4 2021, 5:12 PM
gerritbot added a comment.Feb 6 2021, 3:38 PM

Change 661749 had a related patch set uploaded (by Urbanecm; owner: Urbanecm):
[mediawiki/extensions/GrowthExperiments@master] GEHomepage(Manual)MentorsList should consistently use null for "no list"

https://gerrit.wikimedia.org/r/661749

gerritbot added a comment.Feb 6 2021, 3:39 PM

Change 661751 abandoned by Urbanecm:
[mediawiki/extensions/GrowthExperiments@master] MentorManager::getManuallyAssignedMentorsPage should recognize null as 'no page provided'

Reason:
merged into 661749 https://w.wiki/y3p

https://gerrit.wikimedia.org/r/661751

kostajh moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Feb 9 2021, 8:03 PM
kostajh added subscribers: Etonkovidova, kostajh.

I think this could just be resolved, @Etonkovidova.

gerritbot added a comment.Feb 9 2021, 8:13 PM

Change 661749 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] GEHomepage(Manual)MentorsList should consistently use null for "no list"

https://gerrit.wikimedia.org/r/661749

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.31; 2021-02-16).Feb 9 2021, 9:00 PM
Urbanecm_WMF closed this task as Resolved.Feb 9 2021, 9:08 PM

This is not QA'able yet - we're not setting it to null anywhere. Closing it.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits