In T260862#6816930, @IKhitron wrote:In T260862#6816915, @DannyS712 wrote:In T260862#6816864, @IKhitron wrote:...
- You can add more than five wiki fields on Special:GlobalWatchlistSettings. The settings list should be aware of the wiki variable for maximum number of wikis.
You can add more fields, but you can't save them if there is more than 5 - its allowed to add extra fields because there is no easy way to reorder them
Yes, I know you can't save, but it will be better if you can't add. About an easy way - I suggest to remove the "Add" buttons at all, and always show maximum number of fields, empty or not. On save you read all the fields and filter out the empty ones, in any order.
Description
Description
Related Objects
Related Objects
Event Timeline
Comment Actions
The maximum for the WMF is now at 50 wikis - given this much higher limit, @IKhitron I'm inclined to decline this - the maximum is configurable and we shouldn't always include that many rows, because it may be unwieldy
Comment Actions
And what about to allow to the user to set their own maximum, 10 or 20 or 50, in settings?
Comment Actions
Which actual underlying problem would that solve (which outweighs additional code complexity and maintenance costs)?
Comment Actions
Actually it'll increase the code complexity and maintenance costs - there will now need to be a separate input for the user-provided maximum, and we will have to fetch that before rendering the form, and then take that into account when validating it. See https://www.mediawiki.org/wiki/Just_make_it_a_user_preference more generally.
Comment Actions
Yes, but I'm sorry, what does that have to do with anything? The changes purposed here (remove the option to add more rows and show them all, and/or allow the user to configure their own limit) are not going to affect the functioning of Special:GlobalWatchlist, only that of Special:GlobalWatchlistSettings and related code. Your proposal would increase complexity and maintenance costs, and I haven't yet seen any benefit it would introduce.