Page MenuHomePhabricator

Replace instances of "Stream" with "Collection"
Closed, DeclinedPublic

Description

Task

Some publishers in the library have distinct collections of content that users can apply for. In the Library Card platform we sometimes refer to these as 'streams' and sometimes as 'collections'. This is confusing both for users and for folks translating the tool.

We should update strings (but not variable names for now, for simplicity) anywhere we've used the word 'stream' to instead say 'collection'. These strings might be in python code or in templates.

Good first task

This task has been placed in the good first task category. This means it has been scoped and written in a way that makes it simpler for folks who haven’t contributed to the tool’s development or open source software in the past.

If that’s you, welcome! Please feel free to ask questions here about this specific task or the codebase more generally. We’ll be more than happy to help you and clarify the steps needed to complete the task, whether that’s setting up the repository, implementing the necessary changes, or pushing your changes to Github.

If you have experience contributing to this project or similar ones, please consider leaving this one for someone new, and taking a look at the Open Tasks column of the workboard for another task. Also feel free to help out if you see unanswered questions here!

How to contribute

Assign yourself to this task: Click the ‘Add Action’ dropdown menu below and then select Assign / Claim. The box should fill your username in automatically, then click Submit!

The Library Card platform repository can be found at WikipediaLibrary/TWLight. Please see the Getting Started and Local Setup guides to get up and running with a local development environment.

To submit your changes, you should fork the repository and create a new branch. After pushing your changes to your Github branch, you can open a pull request. Please link your pull request in a comment here when it has been submitted, and include the Phabricator task number in the pull request. Experienced contributors to the project will review your code and either provide feedback or merge it in!

Event Timeline

jsn.sherman subscribed.

Merged, thanks!
This PR made this issue much better, but didn't completely resolve it, so I'm moving this back to ready.

Going to try to change the rest of them in the code :)

Moving this to the backlog to reduce confusion on the team kanban.

@Amire80 do you plan to work on the remaining pieces of this?

Samwalton9-WMF added a subscriber: Amire80.

Unassigning for now :)

Aacaldwell subscribed.

Hi there. Can I work on this?

I do have a question for clarification. Looking through the codebase, I do see several instances of stream or stream(s) and Stream(s). Does those instances of stream needs to be change to collection?

Hi @Aacaldwell - apologies for the delay in responding here. I should have closed this ticket because we're actually going to go in a different direction and remove streams from the tool entirely (T288054).

I'm going to close the PR, sorry that this was wasted time. Perhaps T277154 would be a good task instead - it should involve just finding that string and marking it with translation tags :)