tox:0.5.0
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	hashar
	Feb 17 2021, 5:15 PM

Description

From T274347#6835467 , @EBernhardson wrote:

These images don't appear to work. Ci is failing. A simple reproduction seems to be:

docker run -it --rm --entrypoint /usr/bin/env docker-registry.wikimedia.org/releng/tox:0.5.0 tox
Traceback (most recent call last):
  File "/usr/local/bin/tox", line 7, in <module>
    from tox import cmdline
  File "/usr/local/lib/python3.5/dist-packages/tox/__init__.py", line 9, in <module>
    import pluggy
  File "/usr/local/lib/python3.5/dist-packages/pluggy/__init__.py", line 16, in <module>
    from .manager import PluginManager, PluginValidationError
  File "/usr/local/lib/python3.5/dist-packages/pluggy/manager.py", line 11, in <module>
    import importlib_metadata
  File "/usr/local/lib/python3.5/dist-packages/importlib_metadata/__init__.py", line 88
    dist: Optional['Distribution'] = None
        ^
SyntaxError: invalid syntax

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	jjb: update tox job to use pip from Debian	integration/config	master	+30 -30
	dockerfiles: use pip from distribution	integration/config	master	+107 -6

Customize query in gerrit

Related Objects

Mentioned In: T274347: Add a bypass for the ci-src-setup script
Mentioned Here: T274347: Add a bypass for the ci-src-setup script

Event Timeline

hashar created this task.Feb 17 2021, 5:15 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptFeb 17 2021, 5:15 PM

hashar mentioned this in T274347: Add a bypass for the ci-src-setup script.Feb 17 2021, 5:16 PM

Comparing:

docker run --rm -it --entrypoint pip3 docker-registry.discovery.wmnet/releng/tox:0.4.4-s3 freeze --all

And:

docker run --rm -it --entrypoint pip3 docker-registry.discovery.wmnet/releng/tox:0.5.0 freeze --all

--- tox:0.4.4-s3	2021-02-17 18:19:32.878462822 +0100
+++ tox:0.5.0	2021-02-17 18:19:44.186585333 +0100
@@ -1,16 +1,17 @@
 appdirs==1.4.4
 distlib==0.3.1
 filelock==3.0.12
-importlib-metadata==1.7.0
-importlib-resources==3.0.0
+importlib-metadata==3.4.0
+importlib-resources==5.1.0
 lxml==3.7.1
 pip==8.1.2
 pluggy==0.13.1
-py==1.9.0
-setuptools==49.6.0
+py==1.10.0
+setuptools==53.0.0
 six==1.15.0
-toml==0.10.1
+toml==0.10.2
 tox==3.10.0
-virtualenv==20.0.31
+typing-extensions==3.7.4.3
+virtualenv==20.4.2
 wheel==0.29.0
-zipp==3.1.0
+zipp==3.4.0

I guess something got broken with metadata.

Change 664680 had a related patch set uploaded (by Hashar; owner: Ebernhardson):
[integration/config@master] dockerfiles: use pip from distribution

https://gerrit.wikimedia.org/r/664680

gerritbot added a project: Patch-For-Review.Feb 17 2021, 5:30 PM

Change 664680 merged by jenkins-bot:
[integration/config@master] dockerfiles: use pip from distribution

https://gerrit.wikimedia.org/r/664680

Mentioned in SAL (#wikimedia-releng) [2021-02-17T17:59:43Z] <hashar> Building Docker images for https://gerrit.wikimedia.org/r/c/integration/config/+/664680 # T275049

Maintenance_bot removed a project: Patch-For-Review.Feb 17 2021, 6:10 PM

Successfully published image docker-registry.discovery.wmnet/releng/tox-homer:0.2.0-s1
Successfully published image docker-registry.discovery.wmnet/releng/tox-pywikibot:0.6.0-s1
Successfully published image docker-registry.discovery.wmnet/releng/tox-acme-chief:0.6.0-s1
Successfully published image docker-registry.discovery.wmnet/releng/commit-message-validator:0.6.1-s5
Successfully published image docker-registry.discovery.wmnet/releng/tox-cergen:0.5.0-s1
Successfully published image docker-registry.discovery.wmnet/releng/tox-labs-striker:0.6.0-s1
Successfully published image docker-registry.discovery.wmnet/releng/tox:0.6.0
Successfully published image docker-registry.discovery.wmnet/releng/zuul-cloner:0.2.1-s4
Successfully published image docker-registry.discovery.wmnet/releng/tox-buster:0.3.0
Successfully published image docker-registry.discovery.wmnet/releng/tox-conftool:0.5.0-s1
Successfully published image docker-registry.discovery.wmnet/releng/tox-pyspark:0.7.0-s1
Successfully published image docker-registry.discovery.wmnet/releng/tox-censorshipmonitoring:0.2.0-s1
Successfully published image docker-registry.discovery.wmnet/releng/tox-poolcounter:0.5.0-s1
Successfully published image docker-registry.discovery.wmnet/releng/tox-eventlogging:0.5.0-s1
Successfully published image docker-registry.discovery.wmnet/releng/tox-mysqld:0.6.0-s1

I will get the jobs updated after dinner

Change 664897 had a related patch set uploaded (by Hashar; owner: Hashar):
[integration/config@master] jjb: update tox job to use pip from Debian

https://gerrit.wikimedia.org/r/664897

gerritbot added a project: Patch-For-Review.Feb 17 2021, 8:05 PM

Mentioned in SAL (#wikimedia-releng) [2021-02-17T20:05:32Z] <hashar> Updating all Jenkins jobs for https://gerrit.wikimedia.org/r/664897 # T275049

Looks better, well done @EBernhardson

$ docker run -it --rm --entrypoint /usr/bin/env docker-registry.wikimedia.org/releng/tox:0.6.0 tox
...
Status: Downloaded newer image for docker-registry.wikimedia.org/releng/tox:0.6.0
ERROR: tox config file (either pyproject.toml, tox.ini, setup.cfg) not found

I have updated all the Jenkins jobs to use the new images. So should be fixed now.

That fixed it for https://gerrit.wikimedia.org/r/c/wikimedia/discovery/analytics/+/664645 :]

hashar closed this task as Resolved.Feb 17 2021, 8:20 PM

Change 664897 merged by jenkins-bot:
[integration/config@master] jjb: update tox job to use pip from Debian