Page MenuHomePhabricator

Poor API behavior when the SUL account does not exist
Closed, ResolvedPublic

Description

Completely untested patch

When the SUL account does not exist, meta=globaluserinfo returns a fatal error from the API. The core API query modules, on the other hand, normally just set a "missing" property on the appropriate result node, which allows other modules in the same query to return results.

I'd really like to see something like this as a return from the above URL:

<?xml version="1.0"?>
<api>

<query>
  <globaluserinfo missing="">
    <unattached>
      <account wiki="alswiki" editcount="0" />
      <account wiki="arwiki" editcount="0" />
      <account wiki="cowiki" editcount="1" />
      <account wiki="commonswiki" editcount="0" />
      <account wiki="cswiki" editcount="0" />
      <account wiki="dawiki" editcount="0" />
      <account wiki="dewiki" editcount="0" />
      <account wiki="elwiki" editcount="0" />
      <account wiki="enwikibooks" editcount="0" />
      <account wiki="enwikinews" editcount="0" />
      <account wiki="enwiki" editcount="46" />

...

      <account wiki="yiwiki" editcount="0" />
      <account wiki="zhwiki" editcount="0" />
    </unattached>
  </globaluserinfo>
</query>

</api>

In other words, still include the "unattached" info even when the SUL account is missing. I have no way to test it, but it might be as simple as the attached patch. You'd want to fix the indentation, of course, but I know MediaWiki devs like to review patches without indentation changes.


Version: unspecified
Severity: enhancement
URL: http://en.wikipedia.org/w/api.php?action=query&meta=globaluserinfo&guiuser=Eddie&guiprop=groups|merged|unattached

Attached:

Details

Reference
bz25508

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:18 PM
bzimport set Reference to bz25508.

Done some rough testing, and seems we can get unattached accounts fine when
there isn't a global account

Tweaked and fixed patch applied in r82412

Thankyou! :)

Restricted Application added a subscriber: Cosine02. · View Herald TranscriptOct 16 2020, 5:43 PM