Page MenuHomePhabricator

Duplicate reply links appear for some comments with two signatures
Closed, ResolvedPublic

Description

In T240640, we decided that comments with multiple signatures should only get one [reply] link at the end. It seems like this is not working perfectly, and some comments gets duplicate [reply] links:

(I actually found these pages in the error logs related to T275066. Apparently the second [reply] link is generated for a comment that consists of nothing at all, which causes issues elsewhere.)

Event Timeline

Change 667296 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/DiscussionTools@master] Broken test cases for comments with double signatures

https://gerrit.wikimedia.org/r/667296

Change 667297 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/DiscussionTools@master] Improve merging multiple comments on one paragraph

https://gerrit.wikimedia.org/r/667297

Change 667296 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@master] Broken test cases for comments with double signatures

https://gerrit.wikimedia.org/r/667296

Change 667297 merged by jenkins-bot:
[mediawiki/extensions/DiscussionTools@master] Improve merging multiple comments on one paragraph

https://gerrit.wikimedia.org/r/667297

ppelberg subscribed.

Nice spot, Bartosz.