Page MenuHomePhabricator

Unable to share link to article via Apple Message if title ends with exclamation mark
Open, LowPublic

Assigned To
None
Authored By
Krinkle
Mar 1 2021, 9:06 PM
Referenced Files
F34130618: cap.png
Mar 1 2021, 9:06 PM
F34130615: cap.png
Mar 1 2021, 9:06 PM
Tokens
"Like" token, awarded by Jdlrobson.

Description

For example, when pasting a link to the page https://nl.wikipedia.org/wiki/Red_mijn_vakantie! (about a Dutch TV series), the message gets split upon submission as a broken link and a loose message containing the exclamation mark.

This is presumably due to "smart" logic trying to separate the link from the (wrongly) assumed end of the sentence, e.g. if you were to say "Please go to <link>! Okay?" then this might make sense, I guess?

cap.png (238×798 px, 28 KB)
cap.png (460×454 px, 16 KB)

I'm reporting it on our end because I'm not sure there's a reasonable way for Apple to solve this, as it is indeed common and natural for people to talk with URLs and e.g. follow the link with a comma, full stop or exclamation mark as part of a larger sentence. And it's really us that are being weird by continuing to stick with these akward "almost display title"-like encoded URLs instead of something more interoperable involving slugs that avoid punctuation characters and/or consitently end the path with a slash or file extension (the bug does not happen for /wiki/Foo or /wiki/Foo!/ or /wiki/Foo!.html).

A possible solution would be to treat the exclamation mark similar to how we treat quotes and tildes (per T106793 and T105265).

NOTE: In order to make the above link, I also had to workaround a similar issue in Phabricator:
https://nl.wikipedia.org/wiki/Red_mijn_vakantie!

⚠️ https://nl.wikipedia.org/wiki/Red_mijn_vakantie! (exclamation mark not included, link is broken)

<https://nl.wikipedia.org/wiki/Red_mijn_vakantie!>

https://nl.wikipedia.org/wiki/Red_mijn_vakantie! (works)