Page MenuHomePhabricator
Create Task
Maniphest T276481

wbsearch parameter wbstype lists “form” and “sense” types twice
Closed, ResolvedPublic
Actions

Description

As a developer working with the Wikibase API, I want to get helpful and sensible information about the API, e.g. in the API sandbox.

Problem:
The wbstype parameter to the wbsearch API (class QuerySearchEntities) lists the “form” and “sense” entity types twice on Wikidata. This seems pointless and confusing.

Example:
https://www.wikidata.org/w/api.php?action=help&modules=query%2Bwbsearch

Screenshots/mockups:

Screenshot_2021-03-04 API sandbox - Wikidata.png (278×1 px, 18 KB)

BDD
GIVEN
AND
WHEN
AND
THEN
AND

Acceptance criteria:

  • Each entity type is only listed once.

Open questions:

Details

SubjectRepoBranchLines +/-
Simplify the "WikibaseRepo.EnabledEntityTypes" servicemediawiki/extensions/Wikibasemaster+1 -17
Add EnabledEntityTypesTestmediawiki/extensions/WikibaseLexememaster+52 -0
Customize query in gerrit

Event Timeline

Lucas_Werkmeister_WMDE created this task.Mar 4 2021, 5:16 PM
Reedy moved this task from Unsorted to Non-core-API stuff on the MediaWiki-Action-API board.Jun 5 2023, 12:50 AM
gerritbot added a comment.Aug 23 2023, 9:24 AM

Change 951845 had a related patch set uploaded (by Hoo man; author: Hoo man):

[mediawiki/extensions/WikibaseLexeme@master] Add EnabledEntityTypesTest

https://gerrit.wikimedia.org/r/951845

gerritbot added a project: Patch-For-Review.Aug 23 2023, 9:24 AM

Change 949080 had a related patch set uploaded (by Hoo man; author: Hoo man):

[mediawiki/extensions/Wikibase@master] Simplify the "WikibaseRepo.EnabledEntityTypes" service

https://gerrit.wikimedia.org/r/949080

gerritbot added a comment.Aug 23 2023, 10:07 AM

Change 951845 merged by jenkins-bot:

[mediawiki/extensions/WikibaseLexeme@master] Add EnabledEntityTypesTest

https://gerrit.wikimedia.org/r/951845

gerritbot added a comment.Aug 23 2023, 10:08 AM

Change 949080 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Simplify the "WikibaseRepo.EnabledEntityTypes" service

https://gerrit.wikimedia.org/r/949080

Maintenance_bot removed a project: Patch-For-Review.Aug 23 2023, 10:12 AM
Lucas_Werkmeister_WMDE added a comment.Aug 23 2023, 10:36 AM

Should be testable in production next week:

$ curl -s 'https://www.wikidata.org/w/api.php?action=paraminfo&modules=wbsearchentities&format=json&formatversion=2' | jq -r '.paraminfo.modules | .[] | select(.name == "wbsearchentities") | .parameters | .[] | select(.name == "type") | .type | .[]'
form
form
item
lexeme
property
sense
sense
ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.25; 2023-09-05).Aug 30 2023, 1:01 AM
Lucas_Werkmeister_WMDE closed this task as Resolved.Aug 31 2023, 11:55 AM
Lucas_Werkmeister_WMDE assigned this task to hoo.
$ curl -s 'https://www.wikidata.org/w/api.php?action=paraminfo&modules=wbsearchentities&format=json&formatversion=2' | jq -r '.paraminfo.modules | .[] | select(.name == "wbsearchentities") | .parameters | .[] | select(.name == "type") | .type | .[]'
form
item
lexeme
property
sense

Presto!

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL