Page MenuHomePhabricator

Cannot edit Z4/Type
Closed, ResolvedPublicBUG REPORT

Description

Steps to Reproduce:

  1. Go to https://notwikilambda.toolforge.org/w/index.php?title=ZObject:Z4&action=edit and add a label in a new language, eg German
  2. Click save

Actual Results:

  1. Does not save, gets a wikilambda-invalidzobject error

Expected Results:

  1. Save the edit

The following is theorizing: I think this happened when the front end switched to working on a normalized format, but the wiki still expects the input to be canonicalized. It seems that this particular bug can be resolved by canonicalizing the input partially (here's a patch that does that):

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikiLambda/+/669245

but I am pretty sure that this is doing the canonicalization at the wrong level, so I don't think that's the right solution. But it does allow to store the edit. (It does not pass all tests though).

Event Timeline

Screenshot 2021-03-08 at 09.01.52.png (841×1 px, 176 KB)

This shows the change and the error message.

Change 673073 had a related patch set uploaded (by Jforrester; owner: ArthurPSmith):
[mediawiki/extensions/WikiLambda@master] ZObjectFactory: Validate in-wiki types with list or type-valued keys

https://gerrit.wikimedia.org/r/673073

Change 673073 merged by jenkins-bot:
[mediawiki/extensions/WikiLambda@master] ZObjectFactory: Validate in-wiki types with list or type-valued keys

https://gerrit.wikimedia.org/r/673073