Page MenuHomePhabricator

ArthurPSmith (Arthur Smith)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Oct 5 2015, 2:29 PM (351 w, 1 d)
Availability
Available
LDAP User
Unknown
MediaWiki User
ArthurPSmith [ Global Accounts ]

Recent Activity

May 12 2022

ArthurPSmith added a comment to T307328: Scalability issues of recentchanges table.

I rely heavily on my Wikidata Watchlist. I generally just look at the last 7 days but longer is useful sometimes. I think the proposed 3 and 4 solutions above (splitting out autopatrolled changes) would be a good solution for my purposes - 99% of edits I check are the unpatrolled ones, so if we could keep 30 days of unpatrolled changes and cut the other to 14 days or less I think that would be fine for me. By the way I find ORES essentially useless to evaluate the quality of Wikidata edits.

May 12 2022, 1:20 PM · Wikidata, Wikidata-Campsite (Team A Hearth 🏰🔥), Slow-DB-Query, Performance-Team (Radar), Growth-Team, Data-Persistence (Consultation), MediaWiki-Recent-changes

Jan 10 2022

ArthurPSmith added a comment to T298034: Tester page seems broken.

Note - I've updated to the latest versions of everything as of today (Jan 10) and this is still broken. Moreover, due to changes related to lists (Z10) a bunch of the testers are not working, but I can't update or test them due to this problem!!

Jan 10 2022, 4:17 PM · Abstract Wikipedia UX, Abstract Wikipedia team (Phase η – Generic types)

Jan 6 2022

ArthurPSmith added a comment to T298405: Wikidata/Wikibase Entity Draft Namespace.

I see the merit of this idea at least for properties, but I'm wondering where you envision the property discussion to take place? On the talk page? Would that be preserved somehow (referring back to old proposal discussions is done very often).

Jan 6 2022, 5:34 PM · Wikidata

Dec 20 2021

ArthurPSmith created T298034: Tester page seems broken.
Dec 20 2021, 2:55 PM · Abstract Wikipedia UX, Abstract Wikipedia team (Phase η – Generic types)

Dec 16 2021

ArthurPSmith closed T294375: Functions with multiple testers don't appear to run them all? as Resolved.
Dec 16 2021, 2:24 PM · Abstract Wikipedia team (Phase η – Generic types)
ArthurPSmith added a comment to T294375: Functions with multiple testers don't appear to run them all?.

@Jdforrester-WMF yes, this looks good to me now too. This can close.

Dec 16 2021, 2:23 PM · Abstract Wikipedia team (Phase η – Generic types)

Nov 23 2021

ArthurPSmith added a comment to T296208: mediawiki composer complains about symfony/yaml version specification.

We are locked specifically to 5.3.6 because that's the version that passed security review; per https://libraryupgrader2.wmcloud.org/library/composer/symfony/yaml?branch=main there are a few other users in devdeps and deps but none that should hard-conflict. Did you manually add the dependency, or did you use a composer.local.json file?

Nov 23 2021, 2:23 PM · MW-1.38-notes (1.38.0-wmf.12; 2021-12-06), Abstract Wikipedia team (Phase η – Generic types)

Nov 22 2021

ArthurPSmith added a comment to T296211: Type auto-complete should not show non-types.

It's possible this is only happening for types within a List? I just tried something similar for the types of values of a Pair, and type selection there worked fine.

Nov 22 2021, 6:54 PM · MW-1.38-notes (1.38.0-wmf.26; 2022-03-14), Abstract Wikipedia UX, Abstract Wikipedia team (Phase η – Generic types)
ArthurPSmith created T296211: Type auto-complete should not show non-types.
Nov 22 2021, 6:36 PM · MW-1.38-notes (1.38.0-wmf.26; 2022-03-14), Abstract Wikipedia UX, Abstract Wikipedia team (Phase η – Generic types)
ArthurPSmith created T296208: mediawiki composer complains about symfony/yaml version specification.
Nov 22 2021, 6:29 PM · MW-1.38-notes (1.38.0-wmf.12; 2021-12-06), Abstract Wikipedia team (Phase η – Generic types)

Nov 16 2021

ArthurPSmith added a comment to T295275: Dedicated section on Wikidata Item and Property pages for classifying Properties.

Good points from @MisterSynergy and others above. One other case I often run into is problems caused by item merges; if both original items had P279 statements this can cause significant trouble (for example it is a common source of subclass loops).

Nov 16 2021, 6:29 PM · Wikidata, Wikidata-Campsite

Nov 15 2021

ArthurPSmith added a comment to T295275: Dedicated section on Wikidata Item and Property pages for classifying Properties.

Hmm - I agree with the above that P2860 should not be on this list. If we are including the "partitive" properties like P361 and P527 (taxonomic in the sense that they group parts of something with the whole), what about P355 (subsidiary) and P749 (parent organization), which are used that way for organizations, or other properties of that sort?
On the other hand your list does not include the truly taxonomic property P171 (parent taxon) - which is explicitly a subproperty of P279. P10019 (term in higher taxon) seems to also be a subproperty of P279.

Nov 15 2021, 8:55 PM · Wikidata, Wikidata-Campsite
ArthurPSmith created T295716: Having a Z2K1 value of Z0 raises "internal server error" in running tester.
Nov 15 2021, 6:51 PM · Abstract Wikipedia team (Phase η – Generic types)

Oct 29 2021

ArthurPSmith committed rMSFS5699cda8bbe5: Add some testers (authored by ArthurPSmith).
Add some testers
Oct 29 2021, 2:54 PM
ArthurPSmith added a comment to T291650: Provide pre-defined testers for pre-defined functions.

Screenshot of a passed test:

string_if_test.png (122×474 px, 21 KB)

Oct 29 2021, 2:44 PM · Abstract Wikipedia team (Phase κ – Clean-up), Abstract Wikipedia Fix-It tasks

Oct 26 2021

ArthurPSmith created T294375: Functions with multiple testers don't appear to run them all?.
Oct 26 2021, 5:40 PM · Abstract Wikipedia team (Phase η – Generic types)
ArthurPSmith created T294373: Error messages are lost when a Tester fails.
Oct 26 2021, 5:37 PM · MW-1.38-notes (1.38.0-wmf.9; 2021-11-16), Abstract Wikipedia UX, Abstract Wikipedia team (Phase η – Generic types)
ArthurPSmith created T294371: Builtin for object equality.
Oct 26 2021, 5:33 PM · Abstract Wikipedia team (Phase κ – Clean-up)
ArthurPSmith added a comment to T291650: Provide pre-defined testers for pre-defined functions.

But I just updated function-orchestrator again and things seem ok. So I guess a temporary problem with function-orchestrator. Anyway, all is working now!

Oct 26 2021, 1:03 PM · Abstract Wikipedia team (Phase κ – Clean-up), Abstract Wikipedia Fix-It tasks
ArthurPSmith added a comment to T291650: Provide pre-defined testers for pre-defined functions.

You might need to re-load all your data. :-(

Actually when I started running into problems (including issues related to the changes with the Void and Unit ZObjects) I reloaded everything from scratch yesterday. So that can't be the problem right now.

Oct 26 2021, 12:42 PM · Abstract Wikipedia team (Phase κ – Clean-up), Abstract Wikipedia Fix-It tasks

Oct 25 2021

ArthurPSmith added a comment to T291650: Provide pre-defined testers for pre-defined functions.

And now I'm getting (for every function call) - "error type: wrong content type
type: wrong content type
String The provided object is not a function call" Hmm.

Oct 25 2021, 9:24 PM · Abstract Wikipedia team (Phase κ – Clean-up), Abstract Wikipedia Fix-It tasks
ArthurPSmith added a comment to T291650: Provide pre-defined testers for pre-defined functions.

Tracked it down at least one step: the mediawiki container doesn't use the full container name 'mediawiki_function-orchestrator_1' to talk to the orchestrator, rather just the name provided in the compose file - 'function-orchestrator'. Is this perhaps because I'm using a different version of docker-compose? I think my docker versions are quite up to date...

Oct 25 2021, 9:22 PM · Abstract Wikipedia team (Phase κ – Clean-up), Abstract Wikipedia Fix-It tasks
ArthurPSmith added a comment to T291650: Provide pre-defined testers for pre-defined functions.

Ah, the problem is every function call is returning that same error - the orchestrator is not responding for some reason..

Oct 25 2021, 7:27 PM · Abstract Wikipedia team (Phase κ – Clean-up), Abstract Wikipedia Fix-It tasks
ArthurPSmith added a comment to T291650: Provide pre-defined testers for pre-defined functions.

I've started working on some of these - however, it would be nice to actually be able to run the tests to confirm what I'm doing makes sense. But when I click the button to do so right now I get a Failure with the following message:

Oct 25 2021, 7:20 PM · Abstract Wikipedia team (Phase κ – Clean-up), Abstract Wikipedia Fix-It tasks

Oct 19 2021

ArthurPSmith claimed T291650: Provide pre-defined testers for pre-defined functions.

I'll start taking a look at this!

Oct 19 2021, 5:30 PM · Abstract Wikipedia team (Phase κ – Clean-up), Abstract Wikipedia Fix-It tasks

Oct 12 2021

ArthurPSmith added a comment to T292890: Trying to create a Z14 throws "Cannot read properties of undefined (reading 'filter')" in Vue code.

@DVrandecic I just created an implementation on my copy (just updated with the latest versions of everything pulled from gerrit). Seems like maybe it was a temporary problem?

Oct 12 2021, 3:22 PM · MW-1.38-notes (1.38.0-wmf.5; 2021-10-19), WikiLambda, Abstract Wikipedia team (Phase η – Generic types)

Sep 13 2021

ArthurPSmith added a comment to T275941: Extend the system to support generated instances of Z4/ZTypes by parameterised functions ("Generic types").

Of course this is a very general problem - how do you supply the arguments to a function that is returned from a function call (or perhaps just constructed in place), rather than being a persistent ZObject with an id? Do we have any kind of general solution for this now? I was looking through documentation on metawiki and couldn't find anything...

Sep 13 2021, 7:30 PM · Abstract Wikipedia team (Phase η – Generic types), Epic

Sep 10 2021

ArthurPSmith added a comment to T275941: Extend the system to support generated instances of Z4/ZTypes by parameterised functions ("Generic types").

@DVrandecic I'm trying to work through an example of how, for example, a list of strings would be implemented; is there a document anywhere we have that goes into this in detail? The sticking point I'm on is what would the keys for a specific value of the generic type look like. If the generic list type function is Z9999, then its main key (Z9999K1) would be just the type of the list, right? But that specific value of the type would also have keys - for a list it has "Head" and "Tail" keys. Presumably when you do the function call with Z9999K1 = Z6 (string) then it returns a Z4 object that looks a bit like our current Z10, but with the type for key Z10K1 as Z6 instead of Z1, etc. But how would the "Z10K1" key be referred to now? That is, in this section of what is now in Z10:

Sep 10 2021, 6:05 PM · Abstract Wikipedia team (Phase η – Generic types), Epic

Sep 8 2021

ArthurPSmith added a comment to T282020: Add the type string from Z8 Vue code into the PHP side to show below the page title (currently "ZObject: ZObject").

Do we still want to do this? Or should we mark as resolved for now and wait for Aishwarya's designs?

Sep 8 2021, 4:27 PM · WikiLambda, Abstract Wikipedia team

Aug 25 2021

ArthurPSmith closed T287513: Paper cut: The type (Z1K1) field should link, too (not just other types of Z9/Reference) as Resolved.

This looks to me like it's done - Z802 for example links to Z8 both in view and edit modes - ok if I close it?

Aug 25 2021, 1:54 PM · Abstract Wikipedia UX, Abstract Wikipedia team
ArthurPSmith closed T286561: Create a special page to browse existing functions (or a generic ZObject type lookup page)? as Resolved.

I think this is done now, right?

Aug 25 2021, 1:46 PM · Abstract Wikipedia team (Phase ζ), WikiLambda

Aug 19 2021

ArthurPSmith closed T284694: Enable "What Links Here" to include ZObject references as Resolved.

I think we're done here right? Thanks!

Aug 19 2021, 5:29 PM · WikiLambda, Abstract Wikipedia team
ArthurPSmith claimed T286561: Create a special page to browse existing functions (or a generic ZObject type lookup page)?.

I'll take a look at this unless somebody else was itching to work on it...

Aug 19 2021, 3:46 PM · Abstract Wikipedia team (Phase ζ), WikiLambda

Jun 10 2021

ArthurPSmith added a comment to T284694: Enable "What Links Here" to include ZObject references.

Something like that. Also the link should be removed if all references to one ZObject from another are removed.

Jun 10 2021, 12:14 PM · WikiLambda, Abstract Wikipedia team

Jun 9 2021

ArthurPSmith claimed T284694: Enable "What Links Here" to include ZObject references.
Jun 9 2021, 8:13 PM · WikiLambda, Abstract Wikipedia team
ArthurPSmith created T284694: Enable "What Links Here" to include ZObject references.
Jun 9 2021, 8:13 PM · WikiLambda, Abstract Wikipedia team

Jun 2 2021

ArthurPSmith added a comment to T282020: Add the type string from Z8 Vue code into the PHP side to show below the page title (currently "ZObject: ZObject").

Actually currently it always says "ZObject: Z2" - because it's calling $zobject->getZType() and they are all Z2's at that level.

Jun 2 2021, 8:33 PM · WikiLambda, Abstract Wikipedia team
ArthurPSmith added a comment to T282020: Add the type string from Z8 Vue code into the PHP side to show below the page title (currently "ZObject: ZObject").

If I understand this correctly, the idea is to show the function signature, for example for Z813 ("empty") the Vue code displays "( list: List ): Boolean" - so we want to place that string somewhere near the top of the page under the title...

Jun 2 2021, 3:23 PM · WikiLambda, Abstract Wikipedia team

May 12 2021

ArthurPSmith claimed T282020: Add the type string from Z8 Vue code into the PHP side to show below the page title (currently "ZObject: ZObject").
May 12 2021, 8:32 PM · WikiLambda, Abstract Wikipedia team

Apr 28 2021

ArthurPSmith created T281363: Speed up integration tests.
Apr 28 2021, 1:24 PM · Abstract Wikipedia team

Apr 21 2021

ArthurPSmith closed T278965: Default new ZObject in Create should not require deleting and re-adding Z2K2 key as Resolved.

It's working on notwikilambda! Closing...

Apr 21 2021, 8:39 PM · Abstract Wikipedia team (Phase δ)

Mar 31 2021

ArthurPSmith added a comment to T277077: Z0 should never be stored as a ZID in a ZObject.

Maybe more fundamentally the regex matches should all be adjusted so it's looking for Z[1-9]\d* rather than Z\d+ as a valid Z id?

Mar 31 2021, 7:21 PM · WikiLambda, Abstract Wikipedia team (Phase γ)
ArthurPSmith created T278965: Default new ZObject in Create should not require deleting and re-adding Z2K2 key.
Mar 31 2021, 1:45 PM · Abstract Wikipedia team (Phase δ)

Mar 22 2021

ArthurPSmith added a comment to T278161: Allow case-sensitive or lexical-category-restrictive lexeme search.

Hmm, another strange case is search for L:Kelly - the 3 current matches are for L404650, L361948 and L230178, none of which seem to have the string "kelly" in them. So there's some sort of stemming going on here in addition to the case insensitivity, which would be nice to be able to avoid if possible.

Mar 22 2021, 10:30 PM · Wikidata, Wikidata Lexicographical data
ArthurPSmith created T278162: gloss text entry box is too short and hard to edit.
Mar 22 2021, 6:07 PM · Wikidata Lexicographical data, Wikidata
ArthurPSmith created T278161: Allow case-sensitive or lexical-category-restrictive lexeme search.
Mar 22 2021, 6:03 PM · Wikidata, Wikidata Lexicographical data

Mar 18 2021

ArthurPSmith moved T273221: Measure and indicate Lexeme language completeness, and prompt editors with what more might need doing from Backlog to In progress on the Wikidata-Lexicodays-2021 board.

Denny's posted this notebook: https://public.paws.wmcloud.org/User:DVrandecic_(WMF)/Lexicographic%20coverage.ipynb which does pretty much the above for the language Wikipedia corpora. Results at https://www.wikidata.org/wiki/Wikidata:Lexicographical_coverage
However, I don't think he wants to keep running it, so can we move it somewhere that it will be run regularly by a bot or something? The coverage/completeness data is helpful, and the 'missing' page for each language is a great guide to editors, if it could be kept reasonably up to date.

Mar 18 2021, 2:58 PM · Wikidata-Lexicodays-2021, Wikidata, Epic, Wikidata Lexicographical data
ArthurPSmith added a comment to T277701: Change ZObjectFactory built-in validation to handle optionality.

From the discussion it sounded like we didn't want to (partially) address this by allowing null values for keys (JSON does allow 'null' so it could be done that way, though the UI currently doesn't have a mechanism for entering a null, and further changes would still be needed in ZObjectFactory anyway) - rather the optional key should just be absent from the ZObject. If key had an additional boolean attribute "optional" (itself optional, default false) that would partially address the problem, but not the case where we want exactly 1 of N specific keys to be not null (as for implementation). Eventually each type should have its own in-wiki validator that can take care of all this. There are possibly other mechanisms being considered also. So maybe simplest would be for ZObjectFactory to just treat every key as optional for now?

Mar 18 2021, 1:50 PM · Abstract Wikipedia team (Phase ε), WikiLambda

Mar 17 2021

ArthurPSmith reopened T277067: Z13 and Z501 do not load when running maintenance/update.php as "Open".
Mar 17 2021, 8:01 PM · Abstract Wikipedia team (Phase δ), WikiLambda
ArthurPSmith added a comment to T277067: Z13 and Z501 do not load when running maintenance/update.php .

@Jdforrester-WMF Z501 is now loading, but Z13 still not - you can see this on notwikilambda right now for instance - https://notwikilambda.toolforge.org/wiki/Special:AllPages?from=&to=&namespace=2468

Mar 17 2021, 8:00 PM · Abstract Wikipedia team (Phase δ), WikiLambda
ArthurPSmith added a comment to T276841: Cannot create an instance of Z8/Function.

@Jdforrester-WMF the patch I just uploaded does also fix T276836: Cannot edit Z4/Type - the issue there was indeed the change in normalization. I'm not sure however if my fix for that (denormalizing strings and references in the key validation check) is ideal... but it does seem to work. I added tests that fail without these changes and pass now.

Mar 17 2021, 6:16 PM · Abstract Wikipedia team (Phase γ)
ArthurPSmith added a comment to T276841: Cannot create an instance of Z8/Function.

I'm assuming this is the same issue as T276836: Cannot edit Z4/Type, and that the recent changes to the normalisation code in the front-end API means the operations made clientside are no longer valid?

Mar 17 2021, 3:50 PM · Abstract Wikipedia team (Phase γ)
ArthurPSmith claimed T276841: Cannot create an instance of Z8/Function.
Mar 17 2021, 1:34 PM · Abstract Wikipedia team (Phase γ)
ArthurPSmith added a comment to T276841: Cannot create an instance of Z8/Function.

I see the same problem. Looking into it now!

Mar 17 2021, 1:34 PM · Abstract Wikipedia team (Phase γ)

Mar 10 2021

ArthurPSmith created T277067: Z13 and Z501 do not load when running maintenance/update.php .
Mar 10 2021, 4:59 PM · Abstract Wikipedia team (Phase δ), WikiLambda

Mar 3 2021

ArthurPSmith added a comment to T261465: Z20/Tester type.

Just a note - this has been added to the preloaded ZObjects, but it does not load (missing on notwikilambda.toolforge.org for example) due to the reference to Z7, which does not exist yet. It would probably be helpful to have some indication during the update/load process that loading a particular ZObject like this failed...

Mar 3 2021, 3:55 PM · Abstract Wikipedia team (Phase γ)

Feb 17 2021

ArthurPSmith added a comment to T273567: Adding a key with type Z8 to Z8 lead to a HTTP 500.

After discussion James suggested keeping track of the validation context (basically I think option 4 above) - I'll look into this.

Feb 17 2021, 9:32 PM · Patch-For-Review, Abstract Wikipedia team (Phase γ)

Feb 11 2021

ArthurPSmith added a comment to T273567: Adding a key with type Z8 to Z8 lead to a HTTP 500.

The above patch removes the type registry check (option 3). But maybe another solution would be better in the long run?

Feb 11 2021, 9:43 PM · Patch-For-Review, Abstract Wikipedia team (Phase γ)
ArthurPSmith updated subscribers of T273567: Adding a key with type Z8 to Z8 lead to a HTTP 500.

Ok, I've tracked down the source of the problem... It is indeed an infinite recursion issue, in the validation process.

Feb 11 2021, 7:09 PM · Patch-For-Review, Abstract Wikipedia team (Phase γ)

Feb 10 2021

ArthurPSmith added a comment to T273567: Adding a key with type Z8 to Z8 lead to a HTTP 500.

Note that Z6K1 has value type Z6 and that doesn't cause this problem.

Feb 10 2021, 2:55 PM · Patch-For-Review, Abstract Wikipedia team (Phase γ)
ArthurPSmith claimed T273567: Adding a key with type Z8 to Z8 lead to a HTTP 500.

This is interesting - I'll take a look at it!

Feb 10 2021, 2:53 PM · Patch-For-Review, Abstract Wikipedia team (Phase γ)

Jan 20 2021

ArthurPSmith claimed T266292: Values that are references should display labels.
Jan 20 2021, 9:18 PM · Abstract Wikipedia team (Phase γ), Abstract Wikipedia UX

Jan 14 2021

ArthurPSmith added a comment to T270295: Fix behaviour of SelectZObject component to make it more usable and similar to OOUI component.

Some of my notes on other things the select widget should do that it doesn't do right now...:

Jan 14 2021, 6:59 PM · Abstract Wikipedia team (Phase β), Abstract Wikipedia UX
ArthurPSmith closed T269192: Rewrite the type selector, a subtask of T270295: Fix behaviour of SelectZObject component to make it more usable and similar to OOUI component, as Resolved.
Jan 14 2021, 6:54 PM · Abstract Wikipedia team (Phase β), Abstract Wikipedia UX
ArthurPSmith closed T269192: Rewrite the type selector as Resolved.

TypeSelector has been replaced by SelectZobject, so this can close!

Jan 14 2021, 6:54 PM · Abstract Wikipedia team (Phase β), Abstract Wikipedia UX
ArthurPSmith closed T264828: Get list of types and their keys from wiki, including labels in requested language, a subtask of T266267: Prefill keys when adding an object, as Resolved.
Jan 14 2021, 6:52 PM · Abstract Wikipedia UX, Abstract Wikipedia team (Phase γ)
ArthurPSmith closed T264828: Get list of types and their keys from wiki, including labels in requested language as Resolved.

I think we're done here now? Thanks for all the help guys!

Jan 14 2021, 6:52 PM · Patch-For-Review, Abstract Wikipedia UX, Abstract Wikipedia team (Phase β)
ArthurPSmith added a comment to T264828: Get list of types and their keys from wiki, including labels in requested language.

which was fixed in a patch. All this now deployed!

Jan 14 2021, 5:00 PM · Patch-For-Review, Abstract Wikipedia UX, Abstract Wikipedia team (Phase β)
ArthurPSmith added a comment to T264828: Get list of types and their keys from wiki, including labels in requested language.

See also https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikiLambda/+/656176 which removes the remaining dependencies on the hard-coded types list except for the following:

this.keylabel = editingData.ztypes.Z3;

in OtherKeys.vue.

Jan 14 2021, 3:03 PM · Patch-For-Review, Abstract Wikipedia UX, Abstract Wikipedia team (Phase β)

Jan 12 2021

ArthurPSmith closed T270299: Fix two-way binding on the OtherKeys component as Resolved.

Marking as resolved then, thanks!

Jan 12 2021, 3:42 PM · Abstract Wikipedia team (Phase β), Abstract Wikipedia UX
ArthurPSmith added a comment to T270299: Fix two-way binding on the OtherKeys component.

@gengh does this problem seem fixed now?

Jan 12 2021, 2:47 PM · Abstract Wikipedia team (Phase β), Abstract Wikipedia UX

Jan 7 2021

ArthurPSmith added a comment to T270299: Fix two-way binding on the OtherKeys component.

Ok, I think the amended commit in gerrit now fixes this issue. I looked into the question of why the "otherkeydata" was used, and the problem is the way this component is designed we need something that has all the keys in zobject EXCEPT the Z1 and Z2 keys which are handled in the FullZobject component. If we decide that's unnecessary then we can look into replacing it simply with zobject in this component. Another alternative is maybe to create a computed object which is zobject minus those specific key-value pairs.

Jan 7 2021, 9:28 PM · Abstract Wikipedia team (Phase β), Abstract Wikipedia UX
ArthurPSmith added a comment to T270299: Fix two-way binding on the OtherKeys component.

Able to reproduce now, thanks! It seems to be specific to string values? Not quite sure what's going on; as to why having two different objects representing the same structure; it's probably from the evolution of my thinking about how to do this and learning how vue works. I'll see if I can make the change as you imply, I guess using the zobject value directly?

Jan 7 2021, 6:10 PM · Abstract Wikipedia team (Phase β), Abstract Wikipedia UX

Jan 6 2021

ArthurPSmith added a comment to T270299: Fix two-way binding on the OtherKeys component.

Above change doesn't address the main question here.

Jan 6 2021, 8:40 PM · Abstract Wikipedia team (Phase β), Abstract Wikipedia UX
ArthurPSmith added a comment to T270299: Fix two-way binding on the OtherKeys component.

Oh yeah, I had noticed this was broken and wasn't sure the cause... This gives me a clue on the cause but I'm not sure how to fix. Will think a bit about it but feel free to propose a specific solution!

Jan 6 2021, 7:56 PM · Abstract Wikipedia team (Phase β), Abstract Wikipedia UX

Jan 5 2021

ArthurPSmith closed T271181: persistent toolforge 502/503 errors as Resolved.

Things still seem to be working properly and at least the 5xx errors have disappeared, so i think we can say this is resolved now. It would be nice to know what caused it though!

Jan 5 2021, 7:06 PM · Toolforge
ArthurPSmith added a comment to T271181: persistent toolforge 502/503 errors.

@Kizule and @dcaro - thanks for checking. Yes, the problem appears to have gone away now (8:52 AM EST). But the 11 min load @dcaro saw sounds like a real problem - the examples come from a simple Wikidata Query Service query and it does nothing with them other than list them as links, so there's no way they cause trouble. I'm still wondering why there seem to be a large number of 4xx errors shown in grafana for the last day when I see only 3 in the access log on toolforge.

Jan 5 2021, 2:00 PM · Toolforge
ArthurPSmith created T271181: persistent toolforge 502/503 errors.
Jan 5 2021, 1:13 AM · Toolforge

Dec 22 2020

ArthurPSmith added a comment to T270301: Minimize the times OtherKeys component calls wikilambda_fetch; create a global state manager?.

@gengh this is great, thanks! I was hoping we'd get vuex pieces some time, definitely needed. I'm a little stalled right now on what I was working on because I need to convert a zid to a label (also a very general problem, but this is needed to remove TypeSelector.vue and the dependency on the hardcoded type list); ok if I look at adding that to your key label support?

Dec 22 2020, 8:13 PM · Abstract Wikipedia team (Phase β), Abstract Wikipedia UX

Nov 18 2020

ArthurPSmith added a comment to T263956: Work out how Lucas was able to save a Z6 as a Z2 and stop it from happening again.

Or just test a json array directly - it gets entered (because it is a valid zobject) but causes trouble because it's not a valid *persistent* zobject:

var api = new mw.Api(); var test = api.postWithEditToken({action:'edit',format:'json',title:'ZObject:Z12366', text:'["test", "test2"]', contentformat:'application/json', contentmodel:'zobject'});
Nov 18 2020, 4:52 PM · Abstract Wikipedia team (Phase β)
ArthurPSmith added a comment to T263956: Work out how Lucas was able to save a Z6 as a Z2 and stop it from happening again.

I.e. if you try to save an object that looks like {"Z1K1": "Z10", "Z10K1": ...} that would also fail because it's not in the persistent object format (Z2) but rather a list (Z10) at base. Or any other type that's not Z2.

Nov 18 2020, 4:44 PM · Abstract Wikipedia team (Phase β)
ArthurPSmith added a comment to T263956: Work out how Lucas was able to save a Z6 as a Z2 and stop it from happening again.

hi @Jdforrester-WMF - don't we require the base persistent object always to look like {"Z1K1": "Z2", "Z2K2": (rest of object)} ? Also I'd prefer that the "Z2K1": id key always be defined and match the page name...

Nov 18 2020, 4:42 PM · Abstract Wikipedia team (Phase β)
ArthurPSmith added a comment to T266237: Backend to provide all types (Z4s) defined on the wiki.

Although actually trying to do this, it appears the types listed in the table are not the ZObject id's, but string values - so instead of Z4 you have to query for "ZType". Hmm. That doesn't seem like the right choice long term but I guess we can work with it for now.

Nov 18 2020, 2:51 PM · Abstract Wikipedia team (Phase β)
ArthurPSmith added a comment to T266237: Backend to provide all types (Z4s) defined on the wiki.

So having worked on an autocomplete interaction for the reference type, it seems to me that API (list=wikilambda_searchlabels within the mediawiki query API) could be usefully extended to restrict search results by type; with no query string that could return all ZObjects (up to a limit) of a given type. It already returns id, label combinations for a given language. With type = Z4 that would satisfy this ticket...

Nov 18 2020, 2:06 PM · Abstract Wikipedia team (Phase β)

Oct 12 2020

ArthurPSmith added a comment to T258901: Generic viewer for ZObjects.

Change 633560 in gerrit has this adjustment - I'm not sure how to link it to this ticket though?

Oct 12 2020, 3:52 PM · Patch-For-Review, Abstract Wikipedia team (Phase β)

Oct 8 2020

ArthurPSmith updated subscribers of T265034: Wikilambda API help page broken.
Oct 8 2020, 12:18 PM · Abstract Wikipedia team (Phase β)
ArthurPSmith created T265034: Wikilambda API help page broken.
Oct 8 2020, 12:18 PM · Abstract Wikipedia team (Phase β)

Oct 7 2020

ArthurPSmith added a comment to T258901: Generic viewer for ZObjects.

From stand-up today I'll look at modifying the Vue components to allow a "view" mode as opposed to edit mode.

Oct 7 2020, 8:10 PM · Patch-For-Review, Abstract Wikipedia team (Phase β)
ArthurPSmith claimed T258901: Generic viewer for ZObjects.
Oct 7 2020, 8:09 PM · Patch-For-Review, Abstract Wikipedia team (Phase β)
ArthurPSmith added a comment to T264827: Change the ZObject creation UX so that users are prompted to pick a type, instead of Z2K2 defaulting to a ZString.

I think this should be dealt with by having the default value for Z2K2 be null, not '' (an empty string). Alternatively, just remove the Z2K2 from the default Persistent ZObject.

Oct 7 2020, 1:28 PM · Abstract Wikipedia UX, WikiLambda, Abstract Wikipedia team (Phase δ)
ArthurPSmith added a comment to T263956: Work out how Lucas was able to save a Z6 as a Z2 and stop it from happening again.

Hi Lucas - the problem is a change in the data model so that all stored objects (with a ZID, i.e. a page in the namespace) are of type Z2 - Persistent ZObject. This is assumed by the editing UI, so it was very confused to see a Z6 instead of a Z2 as the stored object. A Z6 (string) should be stored as a Z2 with key Z2K2 being the value (the string itself). So yes, probably best to just delete those two for now.

Oct 7 2020, 1:24 PM · Abstract Wikipedia team (Phase β)

Sep 30 2020

ArthurPSmith added a comment to T258904: Special:CreateZObject.

Just a thought here - I would guess the main difference from the generic ZObject editor for the "Create" process is that there is no page ID yet. Presumably we want to generate the id's automatically - Z3834 followed by Z3835, Z3836, etc. Is there a standard approach to do that reliably? I know Wikidata's had issues with id values for their items (Qxxx...) getting skipped, but at least there doesn't seem to have been any issue with the same ID being generated twice in create. Anyway, whether or not that specific solution is adopted it sounds like that's an extra piece that's different from how normal wiki pages work generally...

Sep 30 2020, 11:51 PM · Patch-For-Review, Abstract Wikipedia team (Phase β)

Sep 23 2020

ArthurPSmith added a comment to T262447: Initial Vue implementation for ZObject editing.

@santhosh there are a few places where English words are used that should be i18n messages - do you know how this should work with Vue in Mediawiki? Is there a good example out there now?

Sep 23 2020, 2:32 PM · Abstract Wikipedia team (Phase β)
ArthurPSmith added a comment to T262447: Initial Vue implementation for ZObject editing.

Latest patchset (19) removes the Object.entries and destructuring bit; really this wasn't needed and if we're sticking with ES5 then it should go.

Sep 23 2020, 2:06 PM · Abstract Wikipedia team (Phase β)
ArthurPSmith added a comment to T262447: Initial Vue implementation for ZObject editing.

and another patchset to fix eslint complaints...

Sep 23 2020, 1:33 AM · Abstract Wikipedia team (Phase β)
ArthurPSmith added a comment to T262447: Initial Vue implementation for ZObject editing.

Patchset 15 fixes the issue with creating new ZObjects! However, it also unintentionally altered the package-lock.json file; I'm not quite sure what happened to change that...

Sep 23 2020, 1:03 AM · Abstract Wikipedia team (Phase β)

Sep 22 2020

ArthurPSmith added a comment to T262447: Initial Vue implementation for ZObject editing.

Patchset 11: call makeEmptyContent if ZObject is new

Sep 22 2020, 5:35 PM · Abstract Wikipedia team (Phase β)
ArthurPSmith added a comment to T262447: Initial Vue implementation for ZObject editing.

And patchset 10 - this was using an API to fetch the labels of keys in the old implementation; obviously that's not available (yet) here, and we might prefer a different solution anyway. So I stripped that out.

Sep 22 2020, 3:19 PM · Abstract Wikipedia team (Phase β)
ArthurPSmith added a comment to T262447: Initial Vue implementation for ZObject editing.

Re-pull from gerrit worked (I think). I've uploaded patchset 9 - basically I've abandoned the special handling for labels as too much has changed there from the old implementation, and it all sort of works (more crudely) with the OtherKeys implementation anyway. No language drop-down any more though... I would have had to completely rewrite those two components.
However, I'm thinking the longer term solution here is to write special components like those for each ZObject type, which will allow special things like the language handling. I sort of have special handling now for lists (Z10) and strings (Z6), though only because those are built in to the representation.

Sep 22 2020, 3:11 PM · Abstract Wikipedia team (Phase β)
ArthurPSmith added a comment to T262447: Initial Vue implementation for ZObject editing.

Hmm, thanks for fixing those things. However, now I'm not sure how to submit my further changes - I get the following message after doing a merge with your changes and then trying 'git review -R':

Sep 22 2020, 2:48 PM · Abstract Wikipedia team (Phase β)