The list of types currently seems hardcoded. It should request the list of types from the wiki, or use an autocomplete/search given what is typed.
The labels should be in the users language.
How to reproduce: add a new key. It then gives you a dropdown field with a list of types. This list does not correspond to the list of types available in the given wiki.
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Gabrielchl | T266267 Prefill keys when adding an object | |||
| Resolved | ArthurPSmith | T264828 Get list of types and their keys from wiki, including labels in requested language | |||
| Resolved | ArthurPSmith | T266237 Backend to provide all types (Z4s) defined on the wiki |
Change 651795 had a related patch set uploaded (by Jforrester; owner: ArthurPSmith):
[mediawiki/extensions/WikiLambda@master] Replace TypeSelector with SelectZobject
Change 651795 merged by jenkins-bot:
[mediawiki/extensions/WikiLambda@master] Replace TypeSelector with SelectZobject
See also https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikiLambda/+/656176 which removes the remaining dependencies on the hard-coded types list except for the following:
this.keylabel = editingData.ztypes.Z3;
in OtherKeys.vue.
this.keylabel = editingData.ztypes.Z3;
which was fixed in a patch. All this now deployed!
Change 656230 had a related patch set uploaded (by ArthurPSmith; owner: ArthurPSmith):
[mediawiki/extensions/WikiLambda@master] Remove the hardcoded list of types (and English labels) from the editing context
Change 656233 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/extensions/WikiLambda@master] Follow-up ecb516fe37: Drop TEMP_TYPES_IN_ENGLISH, no longer read
Change 656233 abandoned by Jforrester:
[mediawiki/extensions/WikiLambda@master] Follow-up ecb516fe37: Drop TEMP_TYPES_IN_ENGLISH, no longer read
Reason:
Arthur got there first in I973eaed760.
Change 656230 merged by jenkins-bot:
[mediawiki/extensions/WikiLambda@master] Remove the hardcoded list of types (and English labels) from the editing context