Page MenuHomePhabricator

Add the type string from Z8 Vue code into the PHP side to show below the page title (currently "ZObject: ZObject")
Open, MediumPublic

Event Timeline

DVrandecic raised the priority of this task from Low to Medium.

If I understand this correctly, the idea is to show the function signature, for example for Z813 ("empty") the Vue code displays "( list: List ): Boolean" - so we want to place that string somewhere near the top of the page under the title...

Actually currently it always says "ZObject: Z2" - because it's calling $zobject->getZType() and they are all Z2's at that level.

As discussed today the plan is to replace this with a type string in the form of "Label (Zxxx)" in general, and for functions ideally add the signature as shown in the Vue code now.

Change 699055 had a related patch set uploaded (by ArthurPSmith; author: ArthurPSmith):

[mediawiki/extensions/WikiLambda@master] Replace 'ZObject' with type label in header

https://gerrit.wikimedia.org/r/699055

Change 699055 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] ZObjectContent: Show type label in header

https://gerrit.wikimedia.org/r/699055

Now:

image.png (262×482 px, 23 KB)

Still needs the type-specific formatting for Z8s and other types.

Do we still want to do this? Or should we mark as resolved for now and wait for Aishwarya's designs?

Do we still want to do this? Or should we mark as resolved for now and wait for Aishwarya's designs?

At some point I was thinking the way to do this is to call a ZObject function that does the formatting we want... yes, I think we should close this for now.

Jdforrester-WMF changed the task status from Open to Stalled.Sep 8 2021, 5:00 PM
Jdforrester-WMF removed ArthurPSmith as the assignee of this task.
Jdforrester-WMF added a subscriber: ArthurPSmith.

Do we still want to do this? Or should we mark as resolved for now and wait for Aishwarya's designs?

I think we should leave it open until it's done, but Stalled until the designs are ready.

Change 1003030 had a related patch set uploaded (by DVrandecic; author: DVrandecic):

[mediawiki/extensions/WikiLambda@master] Remove the ZID from the type in the subtitle

https://gerrit.wikimedia.org/r/1003030

Jdforrester-WMF changed the task status from Stalled to Open.Feb 22 2024, 10:42 PM

Change 1003030 abandoned by Amin Al Hazwani:

[mediawiki/extensions/WikiLambda@master] Remove the type ZID from subtitle

Reason:

Grace is going to work on this, see gerrit 1006616

https://gerrit.wikimedia.org/r/1003030