Page MenuHomePhabricator
Create Task
Maniphest T276945

manageJobs --action repush-abandoned does not work for JobQueueDB
Closed, ResolvedPublic
Actions

Description

The script php maintenance/manageJobs.php --type XXX --action repush-abandoned does nothing in the case the job queue is managed by JobQueueDB (the default).

This is because JobQueueDB::getAllAbandonedJobs is not defined, so the parent method JobQueue::getAllAbandonedJobs is used and it is defined as a placeholder doing nothing.

There is a second sub-issue DivisionByZeroError: Modulo by zero on the line calling $this->getBatchSize() because it is null by default.

Details

SubjectRepoBranchLines +/-
Implement JobQueueDB::getAllAbandonedJobsmediawiki/coreREL1_31+12 -0
Define a batch size in maintenance/manageJobs.phpmediawiki/coreREL1_31+1 -0
Define a batch size in maintenance/manageJobs.phpmediawiki/coreREL1_35+1 -0
Implement JobQueueDB::getAllAbandonedJobsmediawiki/coreREL1_36+12 -0
Implement JobQueueDB::getAllAbandonedJobsmediawiki/coreREL1_35+12 -0
Implement JobQueueDB::getAllAbandonedJobsmediawiki/coremaster+13 -0
Define a batch size in maintenance/manageJobs.phpmediawiki/coremaster+1 -0
Customize query in gerrit

Event Timeline

Seb35 created this task.Mar 9 2021, 3:22 PM
Restricted Application added a project: Platform Engineering. · View Herald TranscriptMar 9 2021, 3:22 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
gerritbot added a comment.Mar 9 2021, 3:47 PM

Change 670213 had a related patch set uploaded (by Seb35; owner: Seb35):
[mediawiki/core@master] Implement JobQueueDB::getAllAbandonedJobs

https://gerrit.wikimedia.org/r/670213

gerritbot added a project: Patch-For-Review.Mar 9 2021, 3:47 PM
gerritbot added a comment.Mar 9 2021, 3:51 PM

Change 670215 had a related patch set uploaded (by Seb35; owner: Seb35):
[mediawiki/core@master] Define a batch size in maintenance/manageJobs.php

https://gerrit.wikimedia.org/r/670215

Seb35 edited projects, added MediaWiki-Core-JobQueue, MediaWiki-Maintenance-system; removed MediaWiki-libs-Rdbms.Mar 9 2021, 5:06 PM
gerritbot added a comment.Mar 9 2021, 8:17 PM

Change 670215 merged by jenkins-bot:
[mediawiki/core@master] Define a batch size in maintenance/manageJobs.php

https://gerrit.wikimedia.org/r/670215

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.35; 2021-03-16).Mar 9 2021, 9:00 PM
BPirkle edited projects, added Platform Team Workboards (External Code Reviews); removed Platform Engineering.Mar 9 2021, 9:14 PM
gerritbot added a comment.Apr 8 2021, 10:28 AM

Change 670213 merged by jenkins-bot:

[mediawiki/core@master] Implement JobQueueDB::getAllAbandonedJobs

https://gerrit.wikimedia.org/r/670213

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.1; 2021-04-13).Apr 8 2021, 11:00 AM
Maintenance_bot removed a project: Patch-For-Review.Apr 8 2021, 11:10 AM
• AMooney removed a project: Platform Team Workboards (External Code Reviews).Apr 14 2021, 8:34 PM
Aklapper added a comment.Apr 14 2021, 10:22 PM

All merged, is there more to do here or can this be resolved?

gerritbot added a comment.Apr 21 2021, 3:40 PM

Change 681642 had a related patch set uploaded (by Reedy; author: Seb35):

[mediawiki/core@REL1_35] Implement JobQueueDB::getAllAbandonedJobs

https://gerrit.wikimedia.org/r/681642

gerritbot added a project: Patch-For-Review.Apr 21 2021, 3:40 PM

Change 681643 had a related patch set uploaded (by Reedy; author: Seb35):

[mediawiki/core@REL1_36] Implement JobQueueDB::getAllAbandonedJobs

https://gerrit.wikimedia.org/r/681643

gerritbot added a comment.Apr 21 2021, 3:44 PM

Change 681645 had a related patch set uploaded (by Reedy; author: Seb35):

[mediawiki/core@REL1_35] Define a batch size in maintenance/manageJobs.php

https://gerrit.wikimedia.org/r/681645

gerritbot added a comment.Apr 21 2021, 3:45 PM

Change 681726 had a related patch set uploaded (by Reedy; author: Seb35):

[mediawiki/core@REL1_31] Define a batch size in maintenance/manageJobs.php

https://gerrit.wikimedia.org/r/681726

gerritbot added a comment.Apr 21 2021, 4:16 PM

Change 681728 had a related patch set uploaded (by Reedy; author: Seb35):

[mediawiki/core@REL1_31] Implement JobQueueDB::getAllAbandonedJobs

https://gerrit.wikimedia.org/r/681728

gerritbot added a comment.Apr 21 2021, 4:16 PM

Change 681642 merged by jenkins-bot:

[mediawiki/core@REL1_35] Implement JobQueueDB::getAllAbandonedJobs

https://gerrit.wikimedia.org/r/681642

gerritbot added a comment.Apr 21 2021, 4:16 PM

Change 681645 merged by jenkins-bot:

[mediawiki/core@REL1_35] Define a batch size in maintenance/manageJobs.php

https://gerrit.wikimedia.org/r/681645

gerritbot added a comment.Apr 21 2021, 4:18 PM

Change 681643 merged by jenkins-bot:

[mediawiki/core@REL1_36] Implement JobQueueDB::getAllAbandonedJobs

https://gerrit.wikimedia.org/r/681643

Reedy closed this task as Resolved.Apr 21 2021, 4:42 PM
gerritbot added a comment.Apr 21 2021, 4:52 PM

Change 681726 merged by jenkins-bot:

[mediawiki/core@REL1_31] Define a batch size in maintenance/manageJobs.php

https://gerrit.wikimedia.org/r/681726

gerritbot added a comment.Apr 21 2021, 4:54 PM

Change 681728 merged by jenkins-bot:

[mediawiki/core@REL1_31] Implement JobQueueDB::getAllAbandonedJobs

https://gerrit.wikimedia.org/r/681728

ReleaseTaggerBot edited projects, added MW-1.31-release-notes, MW-1.36-notes, MW-1.35-notes; removed MW-1.36-notes (1.36.0-wmf.35; 2021-03-16).Apr 21 2021, 5:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits