Do not consider translations that don't have message definition as safe
Closed, ResolvedPublic
Actions

Description

Problem

Currently when processMessageChanges runs with safe imports, messages in other languages that do not have a message definition are treated as safe and imported.

This is also causing messages in message group synchronization cache to time out.

Objective

Do not import translations without definitions. Such import should not be treated as "safe-import".

Optional objectives

List them on Special:ManageMessageGroups, but add a warning (similar to other warnings we have for different conditions). Maybe also shade them more grey.

Details

	Subject	Repo	Branch	Lines +/-
	Ignore messages that don't have message definitions	mediawiki/extensions/Translate	master	+4 -0
	Synchronization: Do not treat translations without definitions safe	mediawiki/extensions/Translate	master	+130 -42

Customize query in gerrit

Event Timeline

abi_ created this task.Mar 9 2021, 4:07 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 9 2021, 4:07 PM

Marking this as medium, similar to what we have for the group synchronization cache.

Change 670227 had a related patch set uploaded (by Abijeet Patro; owner: Abijeet Patro):
[mediawiki/extensions/Translate@master] Synchronization: Do not treat translations without definitions safe

https://gerrit.wikimedia.org/r/670227

gerritbot added a project: Patch-For-Review.Mar 9 2021, 4:29 PM

Nikerabbit renamed this task from Do not consider translations that don't have message defintiion as safe to Do not consider translations that don't have message definition as safe.Mar 9 2021, 7:13 PM

abi_ moved this task from In Progress to In Review on the Language-Team (Language-2021-January-March) board.Mar 15 2021, 4:16 AM

Change 670227 merged by jenkins-bot:
[mediawiki/extensions/Translate@master] Synchronization: Do not treat translations without definitions safe

https://gerrit.wikimedia.org/r/670227

abi_ moved this task from In Review to Recheck after deployment on the Language-Team (Language-2021-January-March) board.Mar 23 2021, 3:00 PM

Maintenance_bot removed a project: Patch-For-Review.Mar 23 2021, 3:10 PM

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.37; 2021-03-30).Mar 23 2021, 4:00 PM

Pginer-WMF edited projects, added Language-Team (Language-2021-April-June); removed Language-Team (Language-2021-January-March).Apr 1 2021, 11:17 AM

Pginer-WMF moved this task from Quarter Backlog to Recheck after deployment on the Language-Team (Language-2021-April-June) board.

abi_ moved this task from Backlog to group management on the MediaWiki-extensions-Translate board.Apr 19 2021, 5:55 AM

Change 681517 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] Ignore messages that don't have message definitions

https://gerrit.wikimedia.org/r/681517

gerritbot added a project: Patch-For-Review.Apr 21 2021, 6:02 AM

Change 681517 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Ignore messages that don't have message definitions

https://gerrit.wikimedia.org/r/681517

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.3; 2021-04-27).Apr 26 2021, 5:00 PM

abi_ closed this task as Resolved.May 3 2021, 1:56 PM

abi_ moved this task from Recheck after deployment to Done on the Language-Team (Language-2021-April-June) board.

This comment was removed by abi_.

Commented on wrong task.

This is done and deployed on Translatewiki.net. Tested it by processing changes on Special:ManageMessageGroup today.

Do not consider translations that don't have message definition as safeClosed, ResolvedPublicActions