Page MenuHomePhabricator

Fix extensions-LDAPGroups github mirror
Closed, ResolvedPublic

Description

for some reason is the GitHub mirror for LDAPGroups now also archived

any chance to get the broken Github mirror fixed?

Event Timeline

hashar subscribed.

Github is case insensitive thus LdapGroups or LDAPGroups are considered the same. As Gerrit replicate both, the last one that got replicated take over and it seems to be the archived LdapGroups one.

I guess we could look at having Gerrit to stop replicating repositories that are marked read-only. Maybe we can deny Gerrit group mediawiki-replication from accessing LdapGroups which should prevent it from being replicated.

hashar claimed this task.

I have added a DENY rule to prevent replication of LdapGroups to Github (the rule can be seen at https://gerrit.wikimedia.org/r/admin/repos/mediawiki/extensions/LdapGroups,access ).

It is still replicated to the Gerrit replica. I have confirmed it by watching the replication log on gerrit1001 in /var/log/gerrit/replication_log.

ssh -p 29418 gerrit.wikimedia.org replication start mediawiki/extensions/LdapGroups:

[2021-03-10 10:27:15,260] scheduling replication mediawiki/extensions/LdapGroups:..all.. => gerrit2@gerrit2001.wikimedia.org:/srv/gerrit/git/mediawiki/extensions/LdapGroups.git
[2021-03-10 10:27:15,261] scheduled mediawiki/extensions/LdapGroups:..all.. => [1008b885] push gerrit2@gerrit2001.wikimedia.org:/srv/gerrit/git/mediawiki/extensions/LdapGroups.git to run after 5s
[2021-03-10 10:29:10,292] Replication to gerrit2@gerrit2001.wikimedia.org:/srv/gerrit/git/mediawiki/extensions/LdapGroups.git started... [CONTEXT pushOneId="1008b885" ]
[2021-03-10 10:29:10,989] Replication to gerrit2@gerrit2001.wikimedia.org:/srv/gerrit/git/mediawiki/extensions/LdapGroups.git completed in 696ms, 115032ms delay, 0 retries [CONTEXT pushOneId="1008b885" ]

And LDAPGroups is still replicated to both Github and the Gerrit replica:

ssh -p 29418 gerrit.wikimedia.org replication start mediawiki/extensions/LDAPGroups:

[2021-03-10 10:29:31,515] scheduling replication mediawiki/extensions/LDAPGroups:..all.. => git@github.com:wikimedia/mediawiki-extensions-LDAPGroups
[2021-03-10 10:29:31,517] scheduled mediawiki/extensions/LDAPGroups:..all.. => [a02f2395] push git@github.com:wikimedia/mediawiki-extensions-LDAPGroups to run after 15s
[2021-03-10 10:29:31,518] scheduling replication mediawiki/extensions/LDAPGroups:..all.. => gerrit2@gerrit2001.wikimedia.org:/srv/gerrit/git/mediawiki/extensions/LDAPGroups.git
[2021-03-10 10:29:31,519] scheduled mediawiki/extensions/LDAPGroups:..all.. => [203b33e2] push gerrit2@gerrit2001.wikimedia.org:/srv/gerrit/git/mediawiki/extensions/LDAPGroups.git to run after 5s
[2021-03-10 10:29:46,517] Replication to git@github.com:wikimedia/mediawiki-extensions-LDAPGroups started... [CONTEXT pushOneId="a02f2395" ]
[2021-03-10 10:29:46,727] Replication to git@github.com:wikimedia/mediawiki-extensions-LDAPGroups completed in 209ms, 15001ms delay, 0 retries [CONTEXT pushOneId="a02f2395" ]
[2021-03-10 10:30:25,795] Replication to gerrit2@gerrit2001.wikimedia.org:/srv/gerrit/git/mediawiki/extensions/LDAPGroups.git started... [CONTEXT pushOneId="203b33e2" ]
[2021-03-10 10:30:26,502] Replication to gerrit2@gerrit2001.wikimedia.org:/srv/gerrit/git/mediawiki/extensions/LDAPGroups.git completed in 707ms, 54277ms delay, 0 retries [CONTEXT pushOneId="203b33e2" ]

Since Github repository names are case insensitives both https://github.com/wikimedia/mediawiki-extensions-LdapGroups and https://github.com/wikimedia/mediawiki-extensions-LDAPGroups point to the same repository. It is now reflecting the proper repository (mediawiki/extensions/LDAPGroups).