Language button icon and inherited mediawiki.ui icons should follow same min-width/-height regiment
Closed, ResolvedPublic2 Estimated Story Points
Actions

Assigned To

Authored By

	Volker_E
	Mar 17 2021, 2:35 PM

Description

Currently min sizes are set equal to normal width/height sizes in mediawiki.ui icons. This leads to unnecessary code duplication in Vector and inconsistency with standard UI library OOUI's implementation.

Details

	Subject	Repo	Branch	Lines +/-
	mediawiki.ui: Use `min-width` and `min-height` in `px` values	mediawiki/core	master	+4 -3

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		ovasileva	T277660 Language button icon should feature opacity based Base10 equivalent color
		Resolved		Volker_E	T277663 Language button icon and inherited mediawiki.ui icons should follow same min-width/-height regiment

Event Timeline

Volker_E created this task.Mar 17 2021, 2:35 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 17 2021, 2:35 PM

Volker_E added a parent task: T277660: Language button icon should feature opacity based Base10 equivalent color.Mar 17 2021, 2:35 PM

Change 673034 had a related patch set uploaded (by VolkerE; owner: VolkerE):
[mediawiki/core@master] mediawiki.ui: Use min-width and min-height in px values

https://gerrit.wikimedia.org/r/673034

gerritbot added a project: Patch-For-Review.Mar 17 2021, 2:44 PM

Jdlrobson moved this task from Needs Analysis to Upcoming on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.Mar 17 2021, 6:37 PM

Jdlrobson moved this task from Upcoming to Ready for Development on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.Mar 18 2021, 5:18 PM

Jdlrobson set the point value for this task to 2.

Jdlrobson moved this task from Ready for Development to Code Review on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.Mar 18 2021, 5:36 PM

Jdlrobson moved this task from Code Review to Ready for Signoff on the Web-Team-Backlog (Kanbanana-FY-2020-21) board.

Change 673034 merged by jenkins-bot:
[mediawiki/core@master] mediawiki.ui: Use min-width and min-height in px values

https://gerrit.wikimedia.org/r/673034

Maintenance_bot removed a project: Patch-For-Review.Mar 18 2021, 6:10 PM

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.36; 2021-03-23).Mar 18 2021, 7:00 PM

Volker_E closed this task as Resolved.Mar 18 2021, 10:33 PM