VisualEditor: no drop-down when editing a wikilink on nds-nlwiki
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Bdijkstra
	Mar 18 2021, 1:55 PM

Description

On all wikis where I've used the VisualEditor, a drop-down appears when editing a wikilink, as shown in the manual. Except not on nds-nlwiki. What's wrong?

Related Objects

Mentioned Here: T252421: Link search function is invalid in VisualEditor on zh.wikipedia.org (due to local MediaWiki:Common.js/edit.js)

Event Timeline

Bdijkstra created this task.Mar 18 2021, 1:55 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 18 2021, 1:55 PM

This is because of the method Array.prototype.intersects defined in https://nds-nl.wikipedia.org/wiki/MediaWiki:Common.js. Extending the native object's prototypes is not supported by MediaWiki: https://www.mediawiki.org/wiki/ResourceLoader/Migration_guide_(users)#Prototyping.

ppelberg moved this task from To Triage to Triaged on the VisualEditor board.Mar 18 2021, 3:07 PM

This is the same issue as T252421 (probably copy-pasted code).

Looks like a few other projects also have it: https://global-search.toolforge.org/?q="Array.prototype.intersects"&namespaces=2%2C4%2C8&title=%28Gadgets-definition%7C.*%5C.%28js%7Ccss%7Cjson%29%29

Wiki	Page title
diq.wikipedia	https://diq.wikipedia.org/wiki/MediaWiki:Common.js
gag.wikipedia	https://gag.wikipedia.org/wiki/MediaWiki:Common.js
hr.wikisource	https://hr.wikisource.org/wiki/MediaWiki:Common.js
nds-nl.wikipedia	https://nds-nl.wikipedia.org/wiki/MediaWiki:Common.js
th.wikipedia	https://th.wikipedia.org/wiki/มีเดียวิกิ:Common.js
th.wikibooks	https://th.wikibooks.org/wiki/มีเดียวิกิ:Common.js
th.wikisource	https://th.wikisource.org/wiki/มีเดียวิกิ:Common.js
zh.wikipedia	https://zh.wikipedia.org/wiki/User:高文海/edit.js
zh.wikipedia	https://zh.wikipedia.org/wiki/User:WhitePhosphorus/磷原子4号/edit.js

In T277753#6925067, @matmarex wrote:

This is because of the method Array.prototype.intersects defined in https://nds-nl.wikipedia.org/wiki/MediaWiki:Common.js. Extending the native object's prototypes is not supported by MediaWiki: https://www.mediawiki.org/wiki/ResourceLoader/Migration_guide_(users)#Prototyping.

Indeed. I removed that function and now it works as expected.

I updated the page on mw.org which was the source of that code: https://www.mediawiki.org/w/index.php?title=Manual:Force_preview&diff=4470155&oldid=4294352&diffmode=source

And all of the other projects: