There seems to be some concerns regarding the stackoverflow answer linked above. that solution seems to accept certain false positives. E.g. we are only really interested in https or http but that solution will allow other protocols, and will accept a host of other weird things provided they are adhere to the rfc 3886 standard

In T277979#7586066, @Raymond_Ndibe wrote:

There seems to be some concerns regarding the stackoverflow answer linked above. that solution seems to accept certain false positives. E.g. we are only really interested in https or http but that solution will allow other protocols, and will accept a host of other weird things provided they are adhere to the rfc 3886 standard

I'm not sure that the version I'm looking at has the problems you are concerned with:

function isValidHttpUrl(string) {
  let url;
  
  try {
    url = new URL(string);
  } catch (_) {
    return false;  
  }

  return url.protocol === "http:" || url.protocol === "https:";
}

Note the check of the protocol as part of the full validation.

I found a couple of tiny issues with the proposed implementation from T277979#7586574:

• It allows whitespace in the URL's path and query string which the Django regex rejects.
  • This seems simple enough to add an additional check for in the js validation.
• It allows a variety of values in the URL's host that are rejected by the Django regex.
  • I think our prior regex did as well actually.

Change 752042 had a related patch set uploaded (by BryanDavis; author: Bryan Davis):

[wikimedia/toolhub@main] ui: Replace URL validation regex with native parser

https://gerrit.wikimedia.org/r/752042

Change 752042 merged by jenkins-bot:

[wikimedia/toolhub@main] ui: Replace URL validation regex with native parser

https://gerrit.wikimedia.org/r/752042

Change 770638 had a related patch set uploaded (by BryanDavis; author: Bryan Davis):

[operations/deployment-charts@master] toolhub: Bump container version to 2022-03-15-002555-production

https://gerrit.wikimedia.org/r/770638

Change 770638 merged by jenkins-bot:

[operations/deployment-charts@master] toolhub: Bump container version to 2022-03-15-002555-production

https://gerrit.wikimedia.org/r/770638