Toolhub URL field doesn't accept Cyrillic characters
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Reedy
	Jan 6 2022, 7:58 PM

Description

Reported on IRC by @Iniquity

I'm suspecting based on T277979: urlRegex frontend validation is fragile and the proposed patch and comments, that it's probably going to be basically any letters/numbers that aren't a-z0-9 that aren't accepted. And as such, arabic, farsi etc etc characters won't be accepted either.

Details

	Subject	Repo	Branch	Lines +/-
	toolhub: Bump container version to 2022-03-15-002555-production	operations/deployment-charts	master	+1 -1
	ui: Replace URL validation regex with native parser	wikimedia/toolhub	main	+79 -10

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved	BUG REPORT	bd808	T298725 Toolhub URL field doesn't accept Cyrillic characters
		Resolved		bd808	T277979 urlRegex frontend validation is fragile

Event Timeline

Reedy created this task.Jan 6 2022, 7:58 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 6 2022, 7:58 PM

Iniquity subscribed.Jan 6 2022, 7:58 PM

Reedy added a subtask: T277979: urlRegex frontend validation is fragile.Jan 6 2022, 7:58 PM

Reedy updated the task description. (Show Details)

SerDIDG subscribed.Jan 6 2022, 8:00 PM

Reedy updated the task description. (Show Details)Jan 6 2022, 8:12 PM

Iniquity added a project: I18n.Jan 6 2022, 8:20 PM

Wow. Yeah this is caused by the regex validation. Let's fix it.

bd808 changed the task status from Open to In Progress.Jan 6 2022, 8:56 PM

bd808 claimed this task.

bd808 changed the status of subtask T277979: urlRegex frontend validation is fragile from Open to In Progress.

bd808 mentioned this in T277979: urlRegex frontend validation is fragile.

bd808 moved this task from Backlog to In Progress on the Toolhub board.

Restricted Application added a project: User-bd808. · View Herald TranscriptJan 6 2022, 8:57 PM

Change 752042 had a related patch set uploaded (by BryanDavis; author: Bryan Davis):

[wikimedia/toolhub@main] ui: Replace URL validation regex with native parser

https://gerrit.wikimedia.org/r/752042

gerritbot added a project: Patch-For-Review.Jan 7 2022, 12:46 AM

bd808 moved this task from To Do to Needs Review/Feedback on the User-bd808 board.Jan 8 2022, 12:10 AM

Change 752042 merged by jenkins-bot:

[wikimedia/toolhub@main] ui: Replace URL validation regex with native parser

https://gerrit.wikimedia.org/r/752042

Maintenance_bot removed a project: Patch-For-Review.Jan 10 2022, 3:10 PM

bd808 moved this task from In Progress to Review on the Toolhub board.Jan 11 2022, 8:35 PM

bd808 closed subtask T277979: urlRegex frontend validation is fragile as Resolved.Jan 31 2022, 8:06 PM

bd808 closed this task as Resolved.Jan 31 2022, 8:12 PM

Change 770638 had a related patch set uploaded (by BryanDavis; author: Bryan Davis):

[operations/deployment-charts@master] toolhub: Bump container version to 2022-03-15-002555-production

https://gerrit.wikimedia.org/r/770638

gerritbot added a project: Patch-For-Review.Mar 15 2022, 12:35 AM

Change 770638 merged by jenkins-bot: