Page MenuHomePhabricator

Address Voice and Tone issues in MW Core Tests
Open, Needs TriagePublic

Description

List as of 2022-07-25:

➜  mediawiki git:(master) ✗ rg '(white|black)[ \-]?list' tests
tests/phpunit/suite.xml
75:		<whitelist addUncoveredFilesFromWhitelist="true">
83:		</whitelist>

tests/phpunit/includes/block/BlockManagerTest.php
280:			MainConfigNames::DnsBlacklistUrls => $options['blacklist'],
281:			MainConfigNames::ProxyWhitelist => $options['whitelist'],
304:			'IP is blacklisted' => [
306:					'blacklist' => [ 'dnsbl.test' ],
310:					'whitelist' => [],
315:			'IP is blacklisted; blacklist has key' => [
317:					'blacklist' => [ [ 'dnsbl.test', 'key' ] ],
321:					'whitelist' => [],
326:			'IP is blacklisted; blacklist is array' => [
328:					'blacklist' => [ [ 'dnsbl.test' ] ],
332:					'whitelist' => [],
337:			'IP is not blacklisted' => [
339:					'blacklist' => [ 'dnsbl.test' ],
343:					'whitelist' => [],
350:					'blacklist' => [],
354:					'whitelist' => [],
359:			'IP is blacklisted and whitelisted; whitelist is not checked' => [
361:					'blacklist' => [ 'dnsbl.test' ],
365:					'whitelist' => [ '127.0.0.1' ],
370:			'IP is blacklisted and whitelisted; whitelist is checked' => [
372:					'blacklist' => [ 'dnsbl.test' ],
376:					'whitelist' => [ '127.0.0.1' ],

tests/phpunit/includes/Permissions/PermissionManagerTest.php
1329:	public function testWhitelistRead( array $whitelist, string $title, bool $shouldAllow ) {
1330:		$this->overrideConfigValue( MainConfigNames::WhitelistRead, $whitelist );

tests/phpunit/includes/specials/SpecialMuteTest.php
82:		$this->userOptionsManager->setOption( $loggedInUser, 'email-blacklist', "999" );
86:		$fauxRequest = new FauxRequest( [ 'wpemail-blacklist' => true ], true );
94:			$this->userOptionsManager->getOption( $loggedInUser, 'email-blacklist' )
105:		$this->userOptionsManager->setOption( $loggedInUser, 'email-blacklist', "999\n" . $targetUser->getId() );
109:		$fauxRequest = new FauxRequest( [ 'wpemail-blacklist' => false ], true );
115:		$this->assertSame( "999", $this->userOptionsManager->getOption( $loggedInUser, 'email-blacklist' ) );

tests/phpunit/includes/specials/SpecialShortPagesTest.php
16:	public function testGetQueryInfoRespectsContentNS( $contentNS, $blacklistNS, $expectedNS ) {
18:			'wgShortPagesNamespaceExclusions' => $blacklistNS,

tests/phpunit/includes/auth/AuthManagerTest.php
2718:		// Session blacklisted
2730:			[ LogLevel::DEBUG, 'blacklisted in session {sessionid}' ],
2745:			[ LogLevel::DEBUG, 'blacklisted in session {sessionid}' ],

tests/phpunit/unit/includes/BadFileLookupTest.php
138:			'Context page not whitelisted' =>
145:			'Bad image with Image: in blacklist' => [ 'Bad2.jpg', null, true ],
146:			'Bad image without prefix in blacklist' => [ 'Bad3.jpg', null, true ],
147:			'Bad image with different namespace in blacklist' => [ 'Bad4.jpg', null, true ],

Related Objects

StatusSubtypeAssignedTask
ResolvedNone
OpenNone

Event Timeline

Change 675348 had a related patch set uploaded (by Jforrester; author: Jforrester):
[mediawiki/core@master] tests: Avoid problematic language in comments and internal code

https://gerrit.wikimedia.org/r/675348

Change 675349 had a related patch set uploaded (by Jforrester; author: Jforrester):
[mediawiki/core@master] parserTests: Avoid problematic language in comments

https://gerrit.wikimedia.org/r/675349

Change 675348 merged by jenkins-bot:
[mediawiki/core@master] tests: Avoid problematic language in comments and internal code

https://gerrit.wikimedia.org/r/675348

Change 675349 merged by jenkins-bot:
[mediawiki/core@master] parserTests: Avoid problematic language in comments

https://gerrit.wikimedia.org/r/675349

Jdforrester-WMF subscribed.

This is merged according to https://gerrit.wikimedia.org/r/c/mediawiki/core/+/675349 Can we mark this as solved @Reedy ?

Not yet. I've updated the list is of today.